Page MenuHomePhabricator

Echo is not triggering notifications when a mention is made while reorganizing comments in the page
Open, LowPublic

Description

A comment such as
https://pt.wikipedia.org/w/index.php?diff=next&oldid=36985845
doesn't trigger a notification and requires the user to make another edit, such as
https://pt.wikipedia.org/w/index.php?diff=next&oldid=36985847

This is a simplified version of the problem reported at
https://pt.wikipedia.org/wiki/Wikipédia_Discussão:Notificações?diff=36985746&oldid=36985587
which happend on this edit:
https://pt.wikipedia.org/wiki/Project_talk:Notificações?diff=36985587


Version: unspecified
Severity: normal

Details

Reference
bz54639

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:17 AM
bzimport added a project: Notifications.
bzimport set Reference to bz54639.
bzimport added a subscriber: Unknown Object (MLST).

Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/287

As reported at
https://pt.wikipedia.org/w/index.php?diff=prev&oldid=37057524
the notification is also not sent if I just replace "*" by "#" in the previous comment before posting my reply:
https://pt.wikipedia.org/wiki/Project_talk:Notifica%C3%A7%C3%B5es?diff=37057373

bsitu wrote:

mention is unfortunately triggered based on text pattern match, it sounds like the pattern misses something, I will see what can be improved,

This edit didn't generate a mention notification either:
https://pt.wikipedia.org/w/index.php?diff=prev&oldid=39309001
Was it because of the accidental "]"?

Also note about edits that only add content, but had to change an existing line to do so:

https://en.wikipedia.org/w/index.php?diff=616264280

== Topic ==
Text. --Foo
: Foo, bar baz. --Bar

Then changed to:

== Topic ==
Text. --Foo
: [[User:Foo|Foo]], bar baz. --Bar
  • Bug 58034 has been marked as a duplicate of this bug. ***

Not that straightforward, but perhaps the new-only idea from T76642: Echo mentions should only fire with "new" signatures/timestamps could work for this as well.

Another example: the edit https://pt.wikipedia.org/w/index.php?diff=41245885 by @Cainamarques didn't trigger a notification.

There was no new mention of you, just a rearrangement of an existing one:

[[Usuário(a):He7d3r|Helder]] 00h59min de 4 de novembro de 2014 (UTC)

In T56639#1013190, @Mattflaschen wrote:

There was no new mention of you, just a rearrangement of an existing one:

There was this: {{U|He7d3r}}.