Page MenuHomePhabricator

thumb.php should output docs if no file specified
Open, LowPublic

Description

low priority issue.

If you just visit thumb.php (plain thumb.php, not thumb_handler.php), with no f parameter specified, it should probably output a list of all possible parameters it takes.


Version: 1.22.0
Severity: enhancement

Details

Reference
bz54749

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:25 AM
bzimport set Reference to bz54749.
bzimport added a subscriber: Unknown Object (MLST).
Bawolff created this task.Sep 28 2013, 11:54 PM

aravikn wrote:

I would like to work on this bug. Would someone assign this to me?

priyrahulmishra wrote:

I have tried to fix it, would you take a look at it

Proposed Patch: http://fpaste.org/85648/94892293/ (the additions are between line 111 to line 118)

Please let me know, if i have understood it correctly and if the patch i working as it should. If not, what do i have to do to fix it.

Thanks.

(In reply to Rahul Mishra from comment #3)

I have tried to fix it, would you take a look at it

Thanks for your fix. But, your patch doesn't seem to be in a diff/patch format. When referring to a patch, its always helpful if you can make it in the std. diff format. You can check here, how to create a diff/patch using git diff command (http://git-scm.com/docs/git-diff). Try to prepare a gerrit patch set so that its easy for other devs to test your code, and debug.
http://www.mediawiki.org/wiki/Gerrit/Tutorial

Change 118822 had a related patch set uploaded by Santosh2201:
thumb.php should output docs if no file specified

https://gerrit.wikimedia.org/r/118822

priyrahulmishra wrote:

thumb.php should output docs if no file specified.

Attached:

(In reply to Rahul Mishra from comment #6)

Created attachment 14846 [details]

Great!This one really looks like a patch. Why dont you push the same into gerrit?
I have added the how-to in Comment#4

Attached:

priyrahulmishra wrote:

(In reply to Tony Thomas from comment #7)

Created attachment 14846 [details]

I have added the how-to in Comment#4

Thanks, for your comment, i was having some problem with my gerrit account, will ask on MediaWiki-General and fix it as fast as possible.

Attached:

Change 119350 had a related patch set uploaded by Nemo bis:
Show an error message when no or invalid parameters are passed to thumb.php

https://gerrit.wikimedia.org/r/119350

Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:12 PM
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:12 PM

Two patches in Gerrit, both need reworking (see comments there).

Restricted Application added a project: Commons. · View Herald TranscriptOct 18 2016, 2:14 PM
Restricted Application added a subscriber: TerraCodes. · View Herald Transcript
Framawiki moved this task from Backlog to Doing on the good first task board.Dec 2 2017, 1:45 PM