Page MenuHomePhabricator

Dragging elements to the end of the page should make a new empty line appear
Closed, ResolvedPublic

Description

When you want to drag an element to the very bottom of the content editable area, the last position available for the cursor is the end of the last sentence.

Usually you want to place elements not at the end of a line, but right after, in a new line. The behavior expected would be to see a new empty line appearing when you drag an element until the end of a page, and the possibility to drop your element in that empty line.

Tested with the {{Languages}} template at https://www.mediawiki.org/wiki/Groups

The last cursor position possible is at the end of the sentence: "... to create your MediaWiki group." Dropping the template after the last dot puts it at the end of the page, in a new line. The end result is correct, but the behavior is unituitive.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51666

Details

Reference
bz54756

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:25 AM
bzimport set Reference to bz54756.

Wikifram wrote:

Only now noticed this. For me, dropping the template after the last dot was not even possible. I could drop it before the last dot, but not after, so for me it was not simply unintuitive, it was wrong. But now, this has been solved apparently, whether by a new VE version or by a Firefox update I don't know.

Note also that for me, on [https://www.mediawiki.org/wiki/Communication?veaction=edit], the "other languages" template at the top is not even visible in VE mode... This is probably a separate bug though.

(In reply to comment #1)

Note also that for me, on
[https://www.mediawiki.org/wiki/Communication?veaction=edit], the "other
languages" template at the top is not even visible in VE mode... This is
probably a separate bug though.

Possibly it is or is related to bug 50284

(In reply to comment #0)

When you want to drag an element to the very bottom of the content editable
area, the last position available for the cursor is the end of the last
sentence.

Usually you want to place elements not at the end of a line, but right after,
in a new line. The behavior expected would be to see a new empty line
appearing when you drag an element until the end of a page, and the
possibility to drop your element in that empty line.

Merging this with bug 51666 which I've re-titled.

(In reply to comment #2)

(In reply to comment #1)

Note also that for me, on
[https://www.mediawiki.org/wiki/Communication?veaction=edit], the "other
languages" template at the top is not even visible in VE mode... This is
probably a separate bug though.

Possibly it is or is related to bug 50284

No, this is because of the code inside the "other languages" template making assumptions which are true for read mode but not for VisualEditor - I think this is an artefact of bug 50172 and a few other issues.

  • This bug has been marked as a duplicate of bug 51666 ***