Page MenuHomePhabricator

Gallery tags do not honour their 'spec'
Closed, DeclinedPublic

Description

According to https://en.wikipedia.org/wiki/Help:Gallery_tag the gallery tag supports various parameters that are ignored on mobile.

These parameters add classes such as .mw-gallery-nolines

I'm not sure where the gallery code resides but this patch will be a good first step:
Change-Id: Iee44632292b89dd2f131d529740e8e6f3306cbda


Version: unspecified
Severity: enhancement

Details

Reference
bz54796

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:28 AM
bzimport set Reference to bz54796.
bzimport added a subscriber: Unknown Object (MLST).
brion added a comment.Sep 30 2013, 6:29 PM

See includes/gallery/* in core for the code generating the galleries ... note it's recently expanded from the 'traditional' gallery layout to some new modes, so documentation and state may or may not match up cleanly at this point.

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/mobile/cards/1268

The gallery CSS is contained in skins/common/shared.css
This file is kinda big though so we probably don't want to put it in mobile.
It would be useful to separate the gallery styles from this file into a single stylesheet file / gallery module that can be loaded when needed rather than for all pages.

Florian updated the task description. (Show Details)Feb 20 2015, 10:05 AM
Florian set Security to None.
Restricted Application added a project: Readers-Web-Backlog. · View Herald TranscriptApr 8 2015, 7:17 AM
Jdlrobson moved this task from Backlog to Bugs on the MobileFrontend board.Jul 20 2015, 5:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2015, 5:15 PM
Jdlrobson moved this task from Bugs to Discussing on the MobileFrontend board.Jul 20 2015, 5:16 PM
MaxSem removed a subscriber: MaxSem.Aug 18 2015, 5:13 PM

We decided to document on the wiki page that we do not plan to support these parameters on the mobile site.