Page MenuHomePhabricator

UploadWizard: The (grey) dialog should not have a spinner with a fixed white background
Closed, ResolvedPublic


Screenshot of problem:

screenshot.png (1×2 px, 178 KB)

A similar issue (T30318) was filed in the past and resolved.

It appears to be back.

Once again (or still), the dialog has a custom spinner that:

  • has a fixed white background (causing it to stand out against the grey background of the dialog for no good reason)
  • doesn't look like other spinners used in MediaWiki (circulating blue dots instead of black lines).

Should probably use the code spinner icon instead.

See Also: T61699



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:29 AM
bzimport added projects: UploadWizard, Design.
bzimport set Reference to bz54814.
bzimport added a subscriber: Unknown Object (MLST).

i.e. use jquery.spinner.js instead of screwing around in the usual write-a-UW-specific-method way. Thanks for catching this, Krinkle.

(In reply to comment #2)

Can I work on this?

Prepare the patch

tinaj1234: Could you please provide a status update and inform us whether you are still working (or still plan to work) on this issue?
Only in case you do not plan to work on this issue anymore, should the assignee be set back to default and the bug status changed from ASSIGNED to NEW?

tinaj1234: I am resetting the assignee of this issue to default because there has been no progress in the last months. Feel free to take it again when you are actually planning to fix this. Thanks.

matmarex set Security to None.

The popup was changed to use OOUI dialog and jquery.spinner in d97dbc9ed0785c931f764d73d034d1ca6a01884e.

pasted_file (515×895 px, 59 KB)

matmarex assigned this task to MarkTraceur.
matmarex removed a subscriber: wikibugs-l-list.