Page MenuHomePhabricator

PronunciationRecording should pass jshint and comply with coding conventions
Closed, ResolvedPublic

Description

MW has coding conventions for JavaScript (https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript)

During GSOC, I deliberately reviewed for some of these issues, but not all. Now, however, the code should be updated to fully comply.

In addition to the items listed there, it should pass jshint (a tool that checks code standards) and there should be a voting Jenkins job for this (so once it passes it stays that way).


Version: unspecified
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:36 AM
bzimport set Reference to bz54907.
Gilles triaged this task as Medium priority.Nov 24 2014, 2:53 PM
Gilles added a subscriber: Gilles.

Change 233095 had a related patch set uploaded (by Ricordisamoa):
Fix many jshint and jscs errors

https://gerrit.wikimedia.org/r/233095

Change 233095 merged by jenkins-bot:
build: Enable jshint and jscs jobs in npm, and make pass

https://gerrit.wikimedia.org/r/233095

hashar claimed this task.