VisualEditor: Make the isRedirect disable check look at the revision being considered, not current revision
Closed, InvalidPublic


When a page is currently a redirect, but has none-redirect versions in its history those versions should be editable in VE but are not. e.g.

To reproduce:

  1. Load any page that is not a redirect in the source editor
  2. Change the page into a redirect and save
  3. View any revision prior to the redirect

Expected behaviour: Old version is editable in VE
Action behaviour: No option is given to edit in VE

Version: unspecified
Severity: minor
See Also:

bzimport set Reference to bz54921.
Thryduulf created this task.Via LegacyOct 3 2013, 3:15 PM
Jdforrester-WMF added a comment.Via ConduitOct 3 2013, 9:00 PM

Will be superseded by bug 50878 once bug 47328 is implemented, but could be done sooner if someone is keen.

Krenair added a comment.Via ConduitJan 29 2014, 12:50 AM

I'm not sure how easy this would be to do... It appears to be based on MediaWiki core's wgIsRedirect, which would need fixing to work out whether the current revision is a redirect (instead of the latest revision of the current page). I'm not sure core even has a function to work that out at the moment. Even in the database, the field to determine if something is a redirect is in the page table instead of the revision table.

Jdforrester-WMF added a comment.Via ConduitApr 28 2014, 5:40 PM

We no longer stop editing of isRedirect pages, so marking as INVALID now.

Add Comment