Page MenuHomePhabricator

_getContentsNaive doesn't honour "recurse" parameter
Closed, DeclinedPublic

Description

Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1403/
Reported by: Anonymous user
Created on: 2012-02-03 21:35:56
Subject: _getContentsNaive doesn't honour "recurse" parameter
Original description:

\--- catlib.py \(révision 9851\)
+++ catlib.py \(copie de travail\)
@@ -170,7 +170,12 @@
sortby=sortby, sortdir=sortdir\):
yield tag, page
if tag == SUBCATEGORY and recurse:
\- for item in page.\_getContentsNaive\(recurse=True,
\+ if recurse:
\+ if type\(recurse\) is int:
\+ newrecurse = recurse - 1
\+ else:
\+ newrecurse = recurse
\+ for item in page.\_getContentsNaive\(recurse=newrecurse,
sortby=sortby, sortdir=sortdir\):
yield item

my version:

guillaume@barbaz:~/src/pywikipedia$ python version.py
Pywikipedia \[http\] trunk/pywikipedia \(r9850, 2012/02/01, 12:21:57\)
Python 2.7.1+ \(r271:86832, Apr 11 2011, 18:13:53\)
\[GCC 4.5.2\]
config-settings:
use\_api = True
use\_api\_login = True
unicode test: ok


Version: compat-(1.0)
Severity: normal
See Also:
https://sourceforge.net/p/pywikipediabot/bugs/1403

Details

Reference
bz55217

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:27 AM
bzimport set Reference to bz55217.
bzimport added a subscriber: Unknown Object (????).
Aklapper triaged this task as Lowest priority.Jun 5 2015, 1:41 PM
Aklapper subscribed.

Pywikibot has two versions: Compat and Core. This task was filed about the older version, called Pywikibot-compat, which is not under active development anymore. Hence I'm lowering the priority of this task to reflect the reality. Unfortunately, the Pywikibot team does not have the manpower to retest every single bug report / feature request against the (maintained) Pywikibot code base. Furthermore, the code base of Pywikibot-Compat has changed a lot compared to the code base of Pywikibot-Core so there is a chance that the problem described in this task might not exist anymore. Please help: Unfortunately manpower is limited and does not allow testing every single reported task again. If you have time and interest in Pywikibot, please upgrade to Pywikibot-Core and add a comment to this task if the problem in this task still happens in Pywikibot-Core (or directly edit the task by removing the Pywikibot-compat project and adding the Pywikibot project to this task). To learn more about Pywikibot and to get involved in its development, please check out https://www.mediawiki.org/wiki/Manual:Pywikibot/Development Thank you for your understanding.

Xqt subscribed.

Won't fix in compat