Page MenuHomePhabricator

VisualEditor: [Regression] "More" menu gets shorter (to -1px) when page scrolls after focus-loss close in Firefox
Closed, ResolvedPublic

Description

Tested on both the Italian and the English Wikipedia;
Reach the bottom of any page: the style drop down menu does not open (it does when you're at the top of the page); the link inspector does not present the list of options.


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55465

Details

Reference
bz55343

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:35 AM
bzimport set Reference to bz55343.

Same bug with « more » menu

Created attachment 13447
Screenshot of the 0px-height menus

These 3 menus have a height of 0px.

I’ve attached a screenshot of these menus without height.

Attached:

55343.png (272×332 px, 18 KB)

  • Bug 55357 has been marked as a duplicate of this bug. ***

From bug 55357:

TeamGale reports:

"while I was getting more down to the page, the drop down menus were getting
"shorter" and sometimes disappear at the very end. I tried it to many pages to
see if it was happening everywhere and it does. I don't know exactly how to
describe it that's why I took screencaps from the page. All three are from the
same page, in different height. See how the drop down menu of "more" can be
seen entirely at the top of the page and how it gradually disappear as I get
closer to the bottom. It's really weird!! The same thing happens when I am
trying to add a wiki link in the article's text and to be honest, that's how I
notice the gradually disappearing."

The screenshot is at [[File:Drop Down Menus.jpg]]

I can reproduce this in Firefox 24 on Linux when using the vector skin, but not
when using Monobook.

Trying to add a link after the end of the first paragraph I get no suggestions
when my window is not maximised. Even when it is maximised it has completely
disappeared by the end of the page.

What seems to matter is where the view is, not where the cursor is.

Can't reproduce it in Chrome, but in Firefox.

Note that (this is difficult to see in the screenshots), the height decreases only when you close and re-open the More menu.

If you open the More menu on top of the page and scroll down, it stays that way and only when you resize the window does the menu grow/shrink (as it should).

But when you close/re-open the menu when scrolled down, it seems to belief the page is shorter than it really is and draw the menu too small (by a factor that relates to how far one scrolls down) until very soon it is completely collapsed.

For me the collapsed point is far from the bottom of the page (I scrolled down a few pixels each time, and after having scrolled a mere 100px it was already completely collapsed).

Krinkle, do I need to file a different bug for the non-working wikilink menu part? Thanks.

(In reply to comment #6)

Krinkle, do I need to file a different bug for the non-working wikilink menu
part? Thanks.

Yes, let's keep that separate. Could be related, but different user end bugs.

Change 88195 had a related patch set uploaded by Trevor Parscal:
Bug 55343 - The amazing mystery of scrollTop and onscroll

https://gerrit.wikimedia.org/r/88195

Change 88195 merged by jenkins-bot:
The amazing mystery of scrollTop and onscroll

https://gerrit.wikimedia.org/r/88195

Change 88225 had a related patch set uploaded by Jforrester:
The amazing mystery of scrollTop and onscroll

https://gerrit.wikimedia.org/r/88225

Change 88226 had a related patch set uploaded by Jforrester:
The amazing mystery of scrollTop and onscroll

https://gerrit.wikimedia.org/r/88226

  • Bug 55362 has been marked as a duplicate of this bug. ***

Change 88225 merged by Robmoen:
The amazing mystery of scrollTop and onscroll

https://gerrit.wikimedia.org/r/88225

Change 88226 merged by Robmoen:
The amazing mystery of scrollTop and onscroll

https://gerrit.wikimedia.org/r/88226

Note that this is fixed and has been deployed to the cluster. Please re-open if it still occurs for you after a refresh.