Page MenuHomePhabricator

CLI Installer should *not* set wgServer if it is not explicitly passed
Closed, ResolvedPublic

Description

Right now, if no --server-url is passed to the CLI installer, it attempts to guess. Since there is not enough information for it to guess correctly, it usually puts up a rather bad guess (localhost, mostly). If, however, we do not guess, and just not set a wgServer, WebRequest will do the guessing - and its guesses are far more accurate, since it has more information to work with.

So if there's no --server-url passed, wgServer shouldn't be set.


Version: unspecified
Severity: normal

Details

Reference
bz55376

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:38 AM
bzimport added a project: MediaWiki-Installer.
bzimport set Reference to bz55376.
bzimport added a subscriber: Unknown Object (MLST).

I meant --server, not --server-url.

Change 87887 had a related patch set uploaded by Yuvipanda:
Do not set wgServer in cli install unless explicitly passed

https://gerrit.wikimedia.org/r/87887

Change 87887 merged by jenkins-bot:
Do not set wgServer in cli install unless explicitly passed

https://gerrit.wikimedia.org/r/87887