Page MenuHomePhabricator

VisualEditor: SyntaxHighligherGeSHi: Bug in Converter throws "Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist."
Open, LowPublic

Description

On editing a page on mediawiki.org

Navigated to
https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS?veaction=edit#Less

Looking in the console I see:
Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist.

The save button is disabled.
I only noticed this after doing a long edit :(


Version: unspecified
Severity: major
URL: https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS?veaction=edit

Details

Reference
bz55453

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:15 AM
bzimport set Reference to bz55453.

Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist. load.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cdata%2Cexperimental%2Cicons-vector%2Cs…:155
ve.dm.Converter.getDomSubtreeFromData load.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cdata%2Cexperimental%2Cicons-vector%2Cs…:155
ve.dm.Converter.getDomFromData load.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cdata%2Cexperimental%2Cicons-vector%2Cs…:148
(anonymous function) load.php?debug=false&lang=en&modules=ext.visualEditor.base%2Cmediawiki%2CviewPageTarget%7Cjquery.by…:94

WFM, Chromium 28 on Ubuntu GNU/Linux 12.04

Oh, sorry, it's something about that page in particular - confirmed on Chromium 28, Ubuntu GNU/Linux 12.04

This was because of breakage in MWSyntaxHighlightNode, and that page 1) contains such a node and 2) is on mw.org where MWSyntaxHighlightNode is actually enabled. This is experimental code that's only enabled on mw.org and nowhere else (although it will be available everywhere else as an opt-in once we get BetaFeatures going).

Change 88901 had a related patch set uploaded by Catrope:
Remove SyntaxHighlight from the experimental set

https://gerrit.wikimedia.org/r/88901

Change 88901 merged by jenkins-bot:
Remove SyntaxHighlight from the experimental set

https://gerrit.wikimedia.org/r/88901

Patch to disable SyntaxHighlight is now merged, so this problem will be suppressed with the production push tomorrow morning; restoring to "ASSIGNED".