Page MenuHomePhabricator

the change made to fix Bug 46864 needs to be undone so that the banners would appear properly in Hebrew Wikivoyage
Closed, ResolvedPublic

Description

Author: wikijunkiemail

Description:
There is now a consensus in the Hebrew Wikivoyage community to switch to the Panoramic banners which have an embedded TOC instead of the standard gray TOC (the same banners which are currently used in the English Wikivoyage). See discussion at https://he.wikivoyage.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%9E%D7%A1%D7%A2:%D7%A7%D7%A8%D7%95%D7%9F_%D7%94%D7%9E%D7%96%D7%A0%D7%95%D7%9F#.D7.91.D7.90.D7.A0.D7.A8.D7.99.D7.9D

Apparently the banners would only work properly for everyone by default if the change made to fix Bug 46864 (https://bugzilla.wikimedia.org/show_bug.cgi?id=46864) is undone.


Version: wmf-deployment
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54648

Details

Reference
bz55501

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:19 AM
bzimport set Reference to bz55501.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

Apparently the banners would only work properly for everyone by default if
the change made to fix Bug 46864
(https://bugzilla.wikimedia.org/show_bug.cgi?id=46864) is undone.

Could you explain the "apparently"? :)

CC'ing Amir who was involved in bug 46864.

wikijunkiemail wrote:

(In reply to comment #1)

(In reply to comment #0)

Apparently the banners would only work properly for everyone by default if
the change made to fix Bug 46864
(https://bugzilla.wikimedia.org/show_bug.cgi?id=46864) is undone.

Could you explain the "apparently"? :)

CC'ing Amir who was involved in bug 46864.

Currently the TOC of the panoramic banners appears with a gray background by default on the Hebrew Wikivoyage for anyone loading a page that uses it (this now happens by default both for the registered users and the non-registered users) which looks bad esthetically and is unreadable (white letters on light gray background). See example...

https://he.wikivoyage.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:%D7%95%D7%99%D7%A7%D7%99%D7%92%27%D7%90%D7%A0%D7%A7%D7%99/%D7%98%D7%99%D7%95%D7%98%D7%94/%D7%95%D7%95%D7%A9%D7%99%D7%A0%D7%92%D7%98%D7%95%D7%9F_%D7%93%D7%99._%D7%A1%D7%99.

Nevertheless, when as a test I enable the "Floated table of contents" option in the preferences (in order to fix bug 46864 the floated TOC was disabled by default for all users), the TOC in the panoramic banner appears correctly as it appears in the English Wikivoyage.

Hmm, hmm. This makes me wonder if I was wrong in closing bug 54648. :((