Page MenuHomePhabricator

mediawiki.inspect returns incorrect values in debug mode
Closed, ResolvedPublic

Description

It does check if it's a real function/CSS info before adding to the total, but if it's not, it just returns 0. It should verify that:

  1. module.script is not an array (that means it's an array of URLs)
  2. module.style.url is not set.

If either is, it should return null.


Version: 1.22.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55618

Details

Reference
bz55553

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:23 AM
bzimport set Reference to bz55553.
bzimport added a subscriber: Unknown Object (MLST).

Change 89175 had a related patch set uploaded by Ori.livneh:
mw.inspect: decline to report module sizes when in debug mode

https://gerrit.wikimedia.org/r/89175

Change 89175 merged by jenkins-bot:
mw.inspect: decline to report module sizes when in debug mode

https://gerrit.wikimedia.org/r/89175

Change 91299 had a related patch set uploaded by Ori.livneh:
mw.inspect: decline to report module sizes when in debug mode

https://gerrit.wikimedia.org/r/91299

Change 91299 merged by jenkins-bot:
mw.inspect: decline to report module sizes when in debug mode

https://gerrit.wikimedia.org/r/91299

(In reply to comment #4)
https://gerrit.wikimedia.org/r/91299

Was only a cherry pick, back to FIXED as of Ori at 2013-10-11 17:29:20 UTC