Generate user config files at runtime, not install time
Closed, ResolvedPublic

Description

Author: yardenack

Description:
I'm packaging pywikibot for Arch Linux here: https://aur.archlinux.org/packages/python2-pywikibot-git/

Packing software for distribution means that install scripts might be run by a different person than the user. Install scripts are not the place for user config, and it's also bad practice to force ANY interactive configs at that stage.

Please don't run generate_user_files.py from setup.py. Find some way to do this at runtime.

Or, ideally, to behave sanely with no configs at all.

At the moment we are just providing a sample config for users to edit, and doing: sed -i /generate_user_files.py/Id setup.py


Version: core-(2.0)
Severity: major
OS: Linux

bzimport added a project: Pywikibot-General.Via ConduitNov 22 2014, 2:25 AM
bzimport added a subscriber: Unknown Object (????).
bzimport set Reference to bz55583.
bzimport created this task.Via LegacyOct 10 2013, 7:51 PM
Legoktm added a comment.Via ConduitOct 10 2013, 9:02 PM

This also blocking packaging for pypi as well.

gerritbot added a comment.Via ConduitDec 15 2013, 4:26 PM

Change 101662 had a related patch set uploaded by Merlijn van Deen:
(bug 55583) Do not create user-config if stdin is not a tty

https://gerrit.wikimedia.org/r/101662

valhallasw added a comment.Via ConduitDec 15 2013, 4:28 PM

yar, does this solve the issue on your end? Rewriting the user-config stuff to behave more sanely (which includes not requiring a user-config to begin with) is a longer-term project.

gerritbot added a comment.Via ConduitDec 15 2013, 4:41 PM

Change 101662 merged by jenkins-bot:
(bug 55583) Do not create user-config if stdin is not a tty

https://gerrit.wikimedia.org/r/101662

bzimport added a comment.Via ConduitDec 31 2013, 7:48 AM

yardenack wrote:

This works, thanks!

Aklapper added a project: pywikibot-core.Via WebNov 27 2014, 4:17 PM

Add Comment