Page MenuHomePhabricator

Fix missing and misplaced dependencies
Closed, ResolvedPublic


In addition to bug 55550, there seem to be at least a couple other places where there are unneeded dependencies, or missing ones.

  • mw.TimedText (in TimedMediaHandler) depends on jquery.ui.dialog, but does not use it directly. This should be removed.
  • ext.tmh.transcodetable - No listed dependencies at all currently, but uses both mw.addDialog (from mw.MwEmbedSupport) and jquery.ui.dialog.

Version: master
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:27 AM
bzimport set Reference to bz55615.

Change 198525 had a related patch set uploaded (by TheDJ):
TimedText: Remove unneeded dependency on jquery.ui.dialog

Change 198525 merged by jenkins-bot:
TimedText: Remove unneeded dependency on jquery.ui.dialog

TheDJ removed a project: Patch-For-Review.
TheDJ moved this task from Doing to Done on the TimedMediaHandler board.