Page MenuHomePhabricator
Create Task
Maniphest T57721

OAuth MediaWiki extension post-submission message is confusing after updating an app's grants
Closed, DeclinedPublic
Actions

Description

After successfully updating grants to an app (at [[testwiki:Special:MWOAuthManageMyGrants/manage/72]]), I get the following message:

Manage account OAuth grants
   Navigation: [Accepted consumer list]

The access token for this consumer has been updated.

Return to Main Page.

There should be a link back to [[testwiki:Special:MWOAuthManageMyGrants/manage/72]]. And I'm not sure "Return to Main Page" is needed at all.

I'm also not sure this post-submission confirmation page is needed. Perhaps it could just reload [[testwiki:Special:MWOAuthManageMyGrants/manage/72]] and output a success message (green checkmark, etc.).

Or perhaps it update without even requiring a reload/refresh.

Version: unspecified
Severity: normal

Details

Reference
bz55721
SubjectRepoBranchLines +/-
Improve management IF return messagesmediawiki/extensions/OAuthmaster+87 -106
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:35 AM
• bzimport added projects: MediaWiki-extensions-OAuth, I18n.
• bzimport set Reference to bz55721.
• bzimport added a subscriber: Unknown Object (MLST).
• MZMcBride created this task.Oct 14 2013, 10:30 PM
• Deskana added a comment.Nov 10 2013, 9:46 PM

Doesn't block deployment. However, does need to be fixed at a higher priority, as it's very confusing.

• Deskana added a comment.Nov 25 2013, 3:46 PM

I'd like to see this changed to "Your preferences for this application have been updated.", with a link to return to preferences instead of the main page.

• Deskana moved this task from Backlog to Consumer wants on the MediaWiki-extensions-OAuth board.Mar 6 2015, 10:41 PM
Tgr updated the task description. (Show Details)Jun 22 2015, 9:18 PM
Tgr set Security to None.
Tgr mentioned this in T63000: On Special:ManageOAuthConsumers, "Return to MediaWiki" should be "Return to OAuth consumer management"..Jun 23 2015, 7:06 AM
Tgr added a parent task: T98880: Improve OAuth management interface.Jun 23 2015, 7:22 AM
Ricordisamoa subscribed.Jun 23 2015, 11:07 AM
• Deskana unsubscribed.Jun 23 2015, 4:36 PM
Tgr subscribed.Jul 1 2015, 8:08 PM

There should be a link back to [[testwiki:Special:MWOAuthManageMyGrants/manage/72]]

I'm not sure that's useful. I just changed my preferences; I probably don't want to go back and change them again. (And if I really want to, the browser's back button still works.)

gerritbot subscribed.Jul 2 2015, 3:22 AM

Change 222239 had a related patch set uploaded (by Gergő Tisza):
Improve management IF return messages

https://gerrit.wikimedia.org/r/222239

gerritbot added a project: Patch-For-Review.Jul 2 2015, 3:22 AM
gerritbot added a comment.Jul 29 2016, 3:27 AM

Change 222239 merged by jenkins-bot:
Improve management IF return messages

https://gerrit.wikimedia.org/r/222239

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).Jul 29 2016, 4:01 AM
Tgr closed this task as Declined.Jul 29 2016, 6:41 AM

As said above, I don't think it makes sense to send the user to update the consumer they just updated. (The main page link is now removed and after management events which have an associated queue (e.g. accepting a proposed consumer <-> proposed queue), there is a link back to the queue.)

Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL