Page MenuHomePhabricator

git-review broken on Ubuntu+ARM
Closed, ResolvedPublic

Description

I am following git-review installation instructions for Debian[1]. Everything works fine until I try to use git-review.

$ sudo apt-get install python-pip
Reading package lists... Done
Building dependency tree
Reading state information... Done
python-pip is already the newest version.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

$ sudo easy_install pip
Searching for pip
Best match: pip 1.0
Adding pip 1.0 to easy-install.pth file
Installing pip script to /usr/local/bin

Using /usr/lib/python2.7/dist-packages
Processing dependencies for pip
Finished processing dependencies for pip

$ sudo pip install git-review
Requirement already satisfied (use --upgrade to upgrade): git-review in /usr/local/lib/python2.7/dist-packages
Requirement already satisfied (use --upgrade to upgrade): argparse in /usr/lib/python2.7 (from git-review)
Cleaning up...

$ which git-review
/usr/local/bin/git-review

$ git remote -v
origin ssh://zfilipin@gerrit.wikimedia.org:29418/qa/browsertests (fetch)
origin ssh://zfilipin@gerrit.wikimedia.org:29418/qa/browsertests (push)

$ git review -s
Traceback (most recent call last):

File "/usr/local/bin/git-review", line 1196, in <module>
  main()
File "/usr/local/bin/git-review", line 1108, in main
  needs_update = latest_is_newer()
File "/usr/local/bin/git-review", line 179, in latest_is_newer
  if not configParser.getboolean("updates", "check"):
File "/usr/lib/python2.7/ConfigParser.py", line 368, in getboolean
  v = self.get(section, option)
File "/usr/lib/python2.7/ConfigParser.py", line 607, in get
  raise NoSectionError(section)

ConfigParser.NoSectionError: No section: 'updates'

$ git review -d 74128
Traceback (most recent call last):

File "/usr/local/bin/git-review", line 1196, in <module>
  main()
File "/usr/local/bin/git-review", line 1108, in main
  needs_update = latest_is_newer()
File "/usr/local/bin/git-review", line 179, in latest_is_newer
  if not configParser.getboolean("updates", "check"):
File "/usr/lib/python2.7/ConfigParser.py", line 368, in getboolean
  v = self.get(section, option)
File "/usr/lib/python2.7/ConfigParser.py", line 607, in get
  raise NoSectionError(section)

ConfigParser.NoSectionError: No section: 'updates'

Could the problem be that the machine has ARM processor?

Environment:

Samsung Chromebook[2]

$ cat /etc/*-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=12.04
DISTRIB_CODENAME=precise
DISTRIB_DESCRIPTION="Ubuntu 12.04.3 LTS"
NAME="Ubuntu"
VERSION="12.04.3 LTS, Precise Pangolin"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu precise (12.04.3 LTS)"
VERSION_ID="12.04"

$ uname -a
Linux localhost 3.4.0 #1 SMP Thu Sep 12 16:20:20 PDT 2013 armv7l armv7l armv7l GNU/Linux

1: http://www.mediawiki.org/wiki/Gerrit/git-review#Debian
2: https://www.google.com/intl/en/chrome/devices/chromebooks.html#ss-cb


Version: wmf-deployment
Severity: normal
See Also:
https://launchpad.net/bugs/1243044

Details

Reference
bz55732

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:35 AM
bzimport added projects: Gerrit, Upstream.
bzimport set Reference to bz55732.
bzimport added a subscriber: Unknown Object (MLST).

By the way, this is the only thing that is preventing me from having a fully functional development environment on that machine.

Andre asked at #wikimedia-dev for more information:

$ git review --version
git-review version 1.23

$ git review -vs
Traceback (most recent call last):

File "/usr/local/bin/git-review", line 1196, in <module>
  main()
File "/usr/local/bin/git-review", line 1108, in main
  needs_update = latest_is_newer()
File "/usr/local/bin/git-review", line 179, in latest_is_newer
  if not configParser.getboolean("updates", "check"):
File "/usr/lib/python2.7/ConfigParser.py", line 368, in getboolean
  v = self.get(section, option)
File "/usr/lib/python2.7/ConfigParser.py", line 607, in get
  raise NoSectionError(section)

ConfigParser.NoSectionError: No section: 'updates'
(precise)z@localhost:~/project/browsertests$

Noting 1.23 WFM on Ubuntu

(In reply to comment #3)

Noting 1.23 WFM on Ubuntu

I did not understand this comment. Is there anything I should do?

demon added a comment.Oct 22 2013, 6:01 AM

(In reply to comment #5)

Looks like there is a workaround:

http://www.mediawiki.org/wiki/Gerrit/Alternatives_to_git-review

That's always been a workaround. Some of us do this daily rather than use git-review.

Adding something like this to git-review.conf fixes the file:

[updates]
check=off