Page MenuHomePhabricator

Language::convertDoubleWidth() doesn't do all it claims (in its name)
Open, LowPublic

Description

It doesn't convert full width punctuations.

On the other hand, I see its only usage is normalization for searches, and what it does now is simply a subset of UtfNormal::toNFKC(). I wonder whether it's possible to drop this function, and just use UtfNormal::toNFKC() (or is it too aggressive or too slow?).


Version: unspecified
Severity: normal
See Also:
T26209
T41501

Details

Reference
bz56080

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:29 AM
bzimport set Reference to bz56080.
bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.Oct 24 2013, 7:49 AM

Hit and run comment: Did you "git blame" to see why it was introduced?

Krinkle added a subscriber: Krinkle.