Page MenuHomePhabricator

License Info for Media Viewer
Closed, ResolvedPublic



If a file is licensed under a Creative Commons license, we want the Media Viewer to display its 'CC' label (e.g. 'CC-BY-SA-3.0'), as described in our Mingle feature requirement (1).

But this doesn't seem to be working as intended on our multimedia alpha prototype (2). For example, the aquarium photo in the attached screenshot (3) is licensed under 'CC-BY-SA-3.0' (hidden category), but that label is not displayed on the alpha prototype.

Instead, it just says 'Licensing Info'. Even if it were not CC, the recommended copy for generic links is 'See license info', as requested on Mingle.

More info about Media Viewer on our project page (3).






Version: unspecified
Severity: normal
See Also:




Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:34 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz56143.

Actually a bug in CommonsMetadata - it's returning "LicenseUrl" instead of "License" on Commons images. We either need to translate LicenseUrls into licenses, or use the existing solution we have based on categories...maybe CommonsMetadata can't see hidden categories on a remote site? Investigate.

Assigning Gergo.

Tgr added a comment.Oct 28 2013, 7:36 AM

CommonsMetadata is intended to run on the central repository, but in our test setup it actually runs on the frontend wiki. It still kind of works, but some things are not accessible for a remote file, and remote categories are one of them. So License (which is based on categories) is not set, only LicenseUrl (which is based on the description page).

So wait.

Will this work once the central repo has CMD on it? Should I try to handle LicenseUrl too?

OK, we now fall back to the file page in _all_ cases. Try the new patch out for size. I'll close this bug since it never actually hit master.

Reopening this bug, because it is still happening on beta for all the photos I uploaded and featured on this page (Hong Kong, Aquarium, Kerala beach, Wikimedia team):

All these photos should display a 'CC-BY-SA-3.0' label in light box view, but are saying 'License info' instead.

Tgr added a comment.Nov 4 2013, 8:35 PM

Unfortunately beta sites use the real Commons, not Commons beta.
So this is more of a bug in our test setup than in MediaViewer/CommonsMetadata.

I can reproduce this problem on as well, which I don't believe is Beta.

None of the CC images I posted on this are showing the correct CC-BY-SA label: (aquarium, nautilus, Kerala beach)

To be clear, I and other user expect the 'Licensing information' label to be replaced by 'CC-BY-SA-3.0' or whatever license we put in when we uploaded a file, as specified here:

This is an important request, which is going to be echoed over and over again by other users until we fulfill it.

Tgr added a comment.Nov 5 2013, 1:01 AM

Apparently Commons is a ForeignDBViaLBRepo, not a ForeignAPIRepo, and CommonsMetadata cannot handle that. This will be complicated...

Tgr added a comment.Nov 5 2013, 1:11 AM
  • Bug 56587 has been marked as a duplicate of this bug. ***

Change 93889 had a related patch set uploaded by Gergő Tisza:
Use description HTML structure instead of categories to identify license

Change 93889 merged by jenkins-bot:
Use description HTML structure instead of categories to identify license

Tgr added a comment.Nov 6 2013, 7:48 PM

This mostly works now; closing it in favor of more specific bugs.

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:20 AM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 14 2015, 8:32 PM