Page MenuHomePhabricator

Architecture review of GWToolset
Closed, ResolvedPublic

Description

Please do architecture review of GWToolset


Version: unspecified
Severity: normal

Details

Reference
bz56179

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:37 AM
bzimport set Reference to bz56179.
greg created this task.Oct 25 2013, 6:45 PM
bd808 added a comment.Oct 25 2013, 7:16 PM

At minimum I would like Aaron to take a look at the usage of UploadStash and the Job classes.

dan-nl added a comment.Nov 6 2013, 8:38 AM
  • initial review date scheduled for friday, 2013-11-01
    • aaron had to cancel since he was not feeling well.
    • gergő tisza recommended separating exceptions representing user errors into a subclass, let other exceptions fall through to top level
    • aaron to add required mvp changes to the meeting etherpad
    • bryan davis to facilitate set-up of a new meeting with aaron if necessary
    • dan to flush out the high level design concept
dan-nl added a comment.Nov 6 2013, 8:39 AM

*https://gerrit.wikimedia.org/r/#/c/93763/ addresses gergő tisza recommendation

dan-nl added a comment.Nov 6 2013, 8:45 AM
  • during the review of https://gerrit.wikimedia.org/r/#/c/93763/
    • gergő mentioned a concern with the special page ajax handler using exit()
    • both bryan and gergő mentioned a concern about the need to swallow E_USER_NOTICE errors
    • dan to investigate using the api instead of the special page to handler ajax requests for the js save metadata mapping call.
  • 2013-07, aaron mentioned a concern about the potential file size of metadata files. he wants us to use the chunked uploads instead of uploading directly to the stash. he sees this as a blocker for phase 1 deploy.
    • working on a solution

after investigating/implementing the use of chunked uploads, i found that the api, would not allow us to upload .xml files. there may be another path that would allow us to do so, but after an irc chat with aaron and chris, they came up with idea to use a “secured/private” filebackend instead. aaron also recommended adding the possibility to download the metadata file from another domain rather than upload it from a local computer.

Closing this, as this has moved on to security review.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:25 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:20 AM