Page MenuHomePhabricator

Revision deletion's radio buttons labelled yes/no can be confusing, replace with hidden/visible
Closed, ResolvedPublic

Description

Mock design

When deleting multiple revisions, the array of radioboxes with "set" and "unset" can be confusing.

Suggestion by User:DMacks is to label one "Hidden" and the other "Visible".

I've uploaded a mock as to what it would look like. Only the messages would be changed.


Version: 1.22.0
Severity: normal

Attached:

Details

Reference
bz56210

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz56210.
Legoktm created this task.Oct 27 2013, 6:48 AM

I am interested in working on getting this bug fixed. Please assign it to me.

TTO added a comment.Oct 28 2013, 11:21 AM

(In reply to comment #1)

I am interested in working on getting this bug fixed. Please assign it to me.

There's a "take" link up the top there, which does this quite well...

Created attachment 13674
When I try to reproduce the same, I get this radio box, and it doesn't have ' Set' or 'Unset'

On reproducing the same, I found that there is no 'Set' or 'Unset' but the Yes or No radio buttons.

Attached:

(In reply to comment #2)

There's a "take" link up the top there, which does this quite well...

TTO: I think new Bugzilla users can't modify bugs. It's an open issue (bug 40497).

"Set/unset" is specific to the English Wikipedia:

  • [[MediaWiki:Revdelete-radio-unset]]
  • [[MediaWiki:Revdelete-radio-set]]

Message key names aside, the default values of these two messages are "no" and "yes" currently (cf. [[mw:MediaWiki:Revdelete-radio-unset]] and [[mw:MediaWiki:Revdelete-radio-set]]).

Resolving this bug should be a simple matter of editing the relevant i18n file in MediaWiki core.

Tony: does that help?

(In reply to comment #5)

"Set/unset" is specific to the English Wikipedia:

  • [[MediaWiki:Revdelete-radio-unset]]
  • [[MediaWiki:Revdelete-radio-set]]

    Message key names aside, the default values of these two messages are "no" and "yes" currently (cf. [[mw:MediaWiki:Revdelete-radio-unset]] and [[mw:MediaWiki:Revdelete-radio-set]]).

    Resolving this bug should be a simple matter of editing the relevant i18n file in MediaWiki core.

    Tony: does that help?

Ofcourse, Will upload the patch in a while.

Created attachment 13675
Changed the revision history deletion page Confusing radio buttons to 'Visible' and 'Hidden'

Changed the default revision history deletion page Radio button labels from 'Yes' or 'No' to 'Visible' or 'Hidden' and changed the Radio button options too.

Gerrit patch link : https://gerrit.wikimedia.org/r/#/c/93163/

Attached:

Change 93163 had a related patch set uploaded by MZMcBride:
Changed the revision history deletion page Confusing radio buttons Changed the radio button to 'Visible' and 'Hidden' from 'Yes' and 'No' andchanged the respective messages shown. Bug: 56210 Change-Id: I4263e9e15241bb705b288b2bb65f9915557bf472

https://gerrit.wikimedia.org/r/93163

Change 93163 merged by jenkins-bot:
Made the revision history deletion page's radio buttons less confusing Changed the radio button to 'Visible' and 'Hidden' from 'Yes' and 'No' and changed the respective label messages.

https://gerrit.wikimedia.org/r/93163

The Visible/hidden text were accidentally mixed. Please fix.

Pxos.Fiwiki wrote:

(In reply to comment #7)

Created attachment 13675 [details]
Changed the revision history deletion page Confusing radio buttons to
'Visible'
and 'Hidden'

Changed the default revision history deletion page Radio button labels from
'Yes' or 'No' to 'Visible' or 'Hidden' and changed the Radio button options
too.

Gerrit patch link : https://gerrit.wikimedia.org/r/#/c/93163/

The messages are not a success now. When changing the visibility of just one revision it say's "edit summary" instead of "hide edit summary".

Attached:

Change 95537 had a related patch set uploaded by Anomie:
Fix revdelete radio button labels

https://gerrit.wikimedia.org/r/95537

Change 95537 merged by jenkins-bot:
Fix revdelete radio button labels

https://gerrit.wikimedia.org/r/95537

Pxos.Fiwiki wrote:

(In reply to comment #13)

Change 95537 merged by jenkins-bot:
Fix revdelete radio button labels

https://gerrit.wikimedia.org/r/95537

The other messages are still wrong. This is a poorly planned and executed change into the system. If there is just one revision to be hidden, the message next to the tick box says now "Edit summary" when it really should say "hide edit summary". The nice "Hidden" and "Visible" radio buttons simply do not appear in the page when there is just one revision to be hidden.

This change should be reverted altogether. It adds confusion instead of lessening it.