Page MenuHomePhabricator

jQuery.valueview.Expert.prototype.draw() should not be responsible for non-edit mode >> getting rid of BifidExpert
Closed, ResolvedPublic


Redefine jQuery.valueview.Expert's draw functions to not be responsible for non-edit mode representation of data values.

For this purpose we should have value formatters in the frontend. Instead of having experts acting as formatters, a formatter factory should be injected into jQuery.valueview widgets just like an ExpertFactory instance is injected there.

This will allow to get rid of the jQuery.valueview.BifidExpert and increase testability of the experts in general as well as reduce their complexity.

Version: unspecified
Severity: normal
Whiteboard: u=dev c=frontend p=13



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:13 AM
bzimport set Reference to bz56259.
bzimport added a subscriber: Unknown Object (MLST).

I don't agree with this bug's current severity/priority rating at all. This is the kind of continuous refactoring that is required to not end up with a huge mess after the next two features got implemented into the component.

Currently we already have a huge mess in the Time/Geo experts, this could be a first step into improving the situation.