Page MenuHomePhabricator

Flow: edit single post link looks and works differently
Open, MediumPublic

Description

If I right-click on a post's pencil icon and open in new tab (or copy the link and paste it), the URL is like
http://ee-flow.wmflabs.org/w/index.php?title=User_talk:Spage&topic[postId]=050803b2ffb50e132562fa163e68c4ac&workflow=05061628bfecb62ef835fa163e68c4ac&action=edit-post

There are some issues with this

  • page title doesn't say I'm editing
  • no link back to the topic or to the board
  • the Save button looks different, it is blue and says [Submit changes]
  • after clicking this I see the updated post in context in its topic (good), but the timestamp on the post remains 10 hours ago

(editing posts in-place is broken on ee-flow right now, there may be other dissimilarities)

I'm giving this minor severity since normally you edit a post in-place within a topic; but unless we preclude viewing and acting on posts in isolation, it needs greater consistency.


Version: master
Severity: minor

Details

Reference
bz56300

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:16 AM
bzimport set Reference to bz56300.
bzimport added a subscriber: Unknown Object (MLST).

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/377, but people from the community are welcome to contribute here and in Gerrit.

I've definitely seen this before (with just the normal "click on pencil icon" editing, not even new-tabbing/link-following). I believe Matthias or Erik mentioned that this is the expected non-JS fallback behavior, so it's probably a case of Flow sporadically dropping JS on the floor.

Not sure what/who fixed it, but it works fine now :)

You can still get to an action=edit-post URL if you right-click on a post's permalink icon, or if you have JavaScript disabled.

The current set of glitches is slightly different:

but the timestamp on the post remains 10 hours ago

  • I think we agreed a post should always be shown in context within its topic.