Page MenuHomePhabricator

Mention notification is broken on talk pages where LiquidThreads is enabled (e.g. [[mw:]] and [[pt:wikibooks:]])
Open, MediumPublic

Description

As tested in the URL above, if a user mentions another user when replying to a post using LQT, the other user is not notified. Maybe this is because Echo requires the comment to be manually signed and LQT warns the user when it does so (since it adds a signature automatically, outside of the wikicode of the commment)?


Version: unspecified
Severity: enhancement
URL: https://pt.wikibooks.org/wiki/T%C3%B3pico:Wikilivros:LiquidThreads/Testes/resposta_(7)?uselang=en

Details

Reference
bz56311

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:17 AM
bzimport added a project: Notifications.
bzimport set Reference to bz56311.
bzimport added a subscriber: Unknown Object (MLST).
He7d3r created this task.Oct 29 2013, 11:55 AM

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/389, but people from the community are welcome to contribute here and in Gerrit.

Change 93508 had a related patch set uploaded by Legoktm:
Remove namespace restriction for mention notifications

https://gerrit.wikimedia.org/r/93508

First issue, any link outside of NS_PROJECT / talk namespaces are ignored. Above patchset will fix that.

Then there is the signature issue. Maybe we should just special case NS_THREAD and ignore the signature requirement for that namespace?

Zoglun added a comment.Dec 7 2013, 9:30 PM

This patch https://gerrit.wikimedia.org/r/93508 does not support Chinese.

Our English version have exactly the same environment and setting as Chinese version.

However, mention only succeed in English ver: http://en.moegirl.org/Talk:Sandbox .

Not Chinese ver: http://zh.moegirl.org/Talk:%E8%AE%A8%E8%AE%BA%E7%89%88#at.E6.8F.90.E5.8F.8A.E9.AA.9A.E6.89.B0.E5.8A.9F.E8.83.BD.E7.8E.B0.E5.B7.B2.E6.94.AF.E6.8C.81.E4.BA.86.7E

Change 93508 merged by jenkins-bot:
Remove namespace restriction for mention notifications

https://gerrit.wikimedia.org/r/93508

(In reply to Kunal Mehta (Legoktm) from comment #3)

Then there is the signature issue. Maybe we should just special case
NS_THREAD and ignore the signature requirement for that namespace?

Since no one else has had any other suggestions since November, I'll look into seeing how hard it will be to implement this.

(In reply to zoglun from comment #4)

This patch https://gerrit.wikimedia.org/r/93508 does not support Chinese.

I think that was bug 53132.

Understandable frustration, but (in)compatibility with LQT is not a "major" bug.

(In reply to Kunal Mehta (Legoktm) from comment #6)

Then there is the signature issue. Maybe we should just special case
NS_THREAD and ignore the signature requirement for that namespace?

Since no one else has had any other suggestions since November, I'll look
into seeing how hard it will be to implement this.

Makes sense but it's not only about signature. Every *new* page creation in NS_THREAD should be considered an add-comment action by interpretDiff() and friends I guess. What to extract as header of the discussion, though?

Legoktm moved this task from Backlog to Needs code on the Notifications board.Jul 6 2015, 9:05 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 6 2015, 9:05 AM
Jdforrester-WMF lowered the priority of this task from Medium to Lowest.Aug 4 2016, 11:33 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.

Nemo_bis raised the priority of this task from Lowest to Medium.Aug 5 2016, 7:32 AM

Looks like "soon" was an underestimation (T113682 is still open).

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 4 2018, 2:26 PM