Page MenuHomePhabricator

Clean up UI element creation
Closed, ResolvedPublic


Should be helper functions, and probably could split up UI creation into a bunch of smaller bits so it's not such a long dredge.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:22 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz56385.
bzimport added a subscriber: Unknown Object (MLST).
Tgr added a comment.Nov 4 2013, 10:15 PM

What do you think about splitting up the whole thing into an interface and a data part? The data part would do the API requests, and only access the interface via setter calls. The interface could then be split up into small modules, each with its own create and setter calls.

That's basically the plan long-term. I'll try to keep pushing it towards the side of goodness and order and try to avoid adding more cruft.

Sort of better now, but still an issue.

Is this still an issue after the moment.js patch got merged? I don't know.

Oh, sorry, wrong bug. Fail.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:24 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:22 AM