Page MenuHomePhabricator

Remove mw.loader.store experiment code
Closed, ResolvedPublic

Description

Change I51cfd5637 adds the ability to opt-in to testing mw.loader.store by manually setting a cookie. This is not a feature that we want to retain after the test phase concludes. When mw.loader.store is adequately tested, the relevant lines of code should be removed from mediawiki.js. This should happen long before the 1.23 release.


Version: 1.23.0
Severity: blocker
URL: https://meta.wikimedia.org/wiki/Research:Module_storage_performance

Details

Reference
bz56397

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz56397.
ori created this task.Oct 30 2013, 10:39 PM

Change 92791 had a related patch set uploaded by Ori.livneh:
mw.loader.store: temporarily allow users to opt-in via cookie

https://gerrit.wikimedia.org/r/92791

Change 92791 merged by jenkins-bot:
mw.loader.store: temporarily allow users to opt-in via cookie

https://gerrit.wikimedia.org/r/92791

ori added a comment.Nov 12 2013, 1:33 AM

I'm changing the scope of the bug to encompass all the temporary scaffolding required for conducting the module storage performance evaluation. I'll tag the relevant changes.

Change 94840 had a related patch set uploaded by Ori.livneh:
Enable module storage for 0.05% of visitors w/storage-capable browsers

https://gerrit.wikimedia.org/r/94840

ori added a comment.Nov 12 2013, 8:27 PM

If localStorage module caching performs poorly and we decide to remove it altogether, Gerrit changes Icafb803a6 & I4fdc3514c may be used to do the cleanup work.

Change 94840 merged by jenkins-bot:
Enable module storage for 0.05% of visitors w/storage-capable browsers

https://gerrit.wikimedia.org/r/94840

Change 96283 had a related patch set uploaded by Ori.livneh:
Enable module storage for 0.05% of visitors w/storage-capable browsers

https://gerrit.wikimedia.org/r/96283

Change 96284 had a related patch set uploaded by Ori.livneh:
Enable module storage for 0.05% of visitors w/storage-capable browsers

https://gerrit.wikimedia.org/r/96284

Change 96284 merged by jenkins-bot:
Enable module storage for 0.05% of visitors w/storage-capable browsers

https://gerrit.wikimedia.org/r/96284

Change 96283 merged by jenkins-bot:
Enable module storage for 0.05% of visitors w/storage-capable browsers

https://gerrit.wikimedia.org/r/96283

Change 97482 had a related patch set uploaded by Ori.livneh:
Remove experiment code for moduleStorage

https://gerrit.wikimedia.org/r/97482

Change 97482 merged by jenkins-bot:
Remove experiment code for moduleStorage

https://gerrit.wikimedia.org/r/97482

Clean up was merged, so this bug is fixed with the current bug summary