Page MenuHomePhabricator

ConfirmEmail displays "requires that you validate" even if it's already valid.
Closed, ResolvedPublic

Description

If you email is already validated and you go to Special:ConfirmEmail, it shows the emailauthenticated message (which makes sense), confirmemail_text), and includes a button that allows you to validate your email.

The latter to make no sense. It is confusing to say, "Your email address was authenticated [...]" (emailauthenticated), but then "{{SITENAME}} requires that you validate your email address before using email features".

The whole page should fork based on whether the email is validated, and if it is, there should be no button. Presumably as a result of this oddity, English Wikipedia has an override which adds, "To check whether you have already confirmed, please see your preferences." Of course, that is just putting work onto the user.

While we're at it, we should consistently use "confirmed", rather than introduce another word ("authenticated") into the UI.


Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45413

Details

Reference
bz56443

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:27 AM
bzimport added a project: MediaWiki-Email.
bzimport set Reference to bz56443.
bzimport added a subscriber: Unknown Object (MLST).

Change 93394 had a related patch set uploaded by IAlex:
Don't show "Send code" button when email is already confirmed on Special:ConfirmEmail

https://gerrit.wikimedia.org/r/93394

Change 93394 merged by jenkins-bot:
Don't show "Send code" button when email is already confirmed on Special:ConfirmEmail

https://gerrit.wikimedia.org/r/93394

(In reply to comment #2)

Change 93394 merged by jenkins-bot:

Don't show "Send code" button when email

is already confirmed on

Special:ConfirmEmail

https://gerrit.wikimedia.org/r/93394

succesfully merged