Page MenuHomePhabricator

'Use this file' dialog can be popped up multiple times
Closed, ResolvedPublic


screenshot with multiple dialogs

The 'use this file' dialog doesn't prevent clicks from going through to underlying UI, including the link that pops up the dialog in the first place -- you can actually pop up multiple copies.

Version: unspecified
Severity: normal
Whiteboard: gci2013


Screen_Shot_2013-11-01_at_4.22.52_PM.png (1×1 px, 588 KB)



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:31 AM
bzimport set Reference to bz56501.

I guess the "best" way to do this would be to set a flag and make sure the flag is false before we open the dialog, then reset it on close.

Not that hard, maybe useful for a new contributor :)

Change 98066 had a related patch set uploaded by Theopolisme:
Prevent multiple "Use this file" windows

Change 98066 merged by jenkins-bot:
Prevent multiple "Use this file" windows

Assuming this bug is FIXED by the patch merged in comment 4.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:25 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:22 AM