Page MenuHomePhabricator
Create Task
Maniphest T58647

VisualEditor: Make byte counter in save dialog use widget accessors rather than $textarea
Closed, ResolvedPublic
Actions

Description

var $textarea = this.editSummaryInput.$input is bad, should just use .getValue() or whatever it is.

Version: unspecified
Severity: enhancement

Details

Reference
bz56647

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:42 AM
• bzimport added projects: VE-deploy-2014-10-09, Technical-Debt.
• bzimport set Reference to bz56647.
Catrope created this task.Nov 6 2013, 12:48 AM
gerritbot added a comment.Oct 8 2014, 8:16 PM

Change 165597 had a related patch set uploaded by SuchetaG:
Replacing $input in save dialog

https://gerrit.wikimedia.org/r/165597

gerritbot added a comment.Oct 8 2014, 8:26 PM

Change 165597 merged by jenkins-bot:
Replacing $input in save dialog

https://gerrit.wikimedia.org/r/165597

Jdforrester-WMF added a comment.Oct 8 2014, 8:35 PM

Masked by bug 71837.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL