Page MenuHomePhabricator

Grey "Automatically enable all new beta features" label looks disabled
Closed, ResolvedPublic


The grey "Automatically enable all new beta features" label looks disabled.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:17 AM
bzimport set Reference to bz56743.
matmarex created this task.Nov 7 2013, 10:00 PM

I had the exact same reaction, for what it is worth.

Thanks for bringing this up, While in general we probably don't want to use pure black type, the original design for beta features had a white background, where as the actual implementation inherited the grey background from preferences, causing there to be a lot less contrast in the text.

I think we could darken the text more, however I think it should be a bit different then the body text above.

Hmm, there's no need to over-design here -- pure black is consistent with everything else in [[Special:Preferences]].

Change 97300 had a related patch set uploaded by Bartosz Dziewoński:
Removing CSS for auto-enroll option label

Regardless of what color text we use for preferences in general, there's no need to make this one particular preference have a special font color (especially not grey which typically means disabled).

Change 97300 merged by jenkins-bot:
Removing CSS for auto-enroll option label

I'm just going to be bold and merge Kaldari's patch. The exact color can be decided on later, but the current grey is definitely not okay.

Thanks, Ryan and Bartosz!