Page MenuHomePhabricator

CirrusSearch should catch Elasticsearch query parse errors and try again with a more tolerant method
Closed, ResolvedPublic

Description

CirrusSearch does a lot to make sure that the query submitted by the user parses to a valid query_string search. This mostly works but we keep finding funky queries that need escaping. Right now when the query string doesn't parse we get a "temporary search error" that we through back to the user. We should instead catch these errors, warn so we can find them and fix them, and then try using a more permissive query method. We don't use that method by default because it doesn't support a bunch of the syntax that our users expect. Not getting your syntax is better than getting an error.


Version: unspecified
Severity: normal

Details

Reference
bz56877

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:27 AM
bzimport added a project: CirrusSearch.
bzimport set Reference to bz56877.
bzimport added a subscriber: Unknown Object (MLST).

Change 110084 had a related patch set uploaded by Manybubbles:
Catch parse errors from Elasticsearch and retry

https://gerrit.wikimedia.org/r/110084

Change 110084 merged by jenkins-bot:
Catch parse errors from Elasticsearch and retry

https://gerrit.wikimedia.org/r/110084