Page MenuHomePhabricator

Font preference is not saved
Closed, ResolvedPublic

Description

To reproduce:

  1. Open ULS.
  2. Select English.
  3. Go to Fonts.
  4. Select OpenDyslexic as the font for English.
  5. Click Apply.
  6. Go to another page.

Observed: the font is still "system font".

Expected: the font must be "OpenDyslexic".

This is broken with any font change - OpenDyslexic is just an example.

When trying to debug it, Niklas found that the API call to save the fonts is called twice - once with the old font and once with the new. The call with the old font shouldn't happen.

This is somewhat intermittent, probably because of a race condition. In Chrome it is more likely to work as expected and in Firefox it usually fails.


Version: unspecified
Severity: critical

Details

Reference
bz56885

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:27 AM
bzimport set Reference to bz56885.
Amire80 created this task.Nov 11 2013, 6:25 AM

I also found that the two api calls come from input settings and display settings.

Change 94871 had a related patch set uploaded by Santhosh:
Validate the dirty flag before saving preferences in each modules

https://gerrit.wikimedia.org/r/94871

Change 94871 merged by jenkins-bot:
Validate the dirty flag before saving preferences in each modules

https://gerrit.wikimedia.org/r/94871

Change 96716 had a related patch set uploaded by Nikerabbit:
Fix and enable feature Persistent settings

https://gerrit.wikimedia.org/r/96716

Change 96716 merged by jenkins-bot:
Fix and enable feature Persistent settings

https://gerrit.wikimedia.org/r/96716

I still have issues with saving fonts.

[17:05:09] Amir E. Aharoni: OK, so:
[17:05:14] Amir E. Aharoni: going to my wiki...
[17:05:30] Amir E. Aharoni: clicking ULS...
[17:05:38] Amir E. Aharoni: Display settings...
[17:05:54] Amir E. Aharoni: Change English to OpenDyslexic...
[17:05:59] Amir E. Aharoni: Click Input.
[17:06:16] Amir E. Aharoni: Select transliteration for Malayalam.
[17:06:21] Amir E. Aharoni: Apply...
[17:06:27] Amir E. Aharoni: Reload...
[17:06:31] Amir E. Aharoni: <drumroll>
[17:06:43] Amir E. Aharoni: Expected: OpenDyslexic.
[17:06:50] Amir E. Aharoni: Observed: Not OpenDyslexic.
[17:07:18] Amir E. Aharoni: Does that work for you?
[17:07:32] Niklas Laxström: logged in our logged out?
[17:07:38] Amir E. Aharoni: Logged in.
[17:07:45] Niklas Laxström: English is content or interface?
[17:07:49] Amir E. Aharoni: Both.
[17:08:06] Niklas Laxström: started and incognito with Chrome
[17:08:12] Niklas Laxström: logged in to https://dev.translatewiki.net/wiki/Main_Page
[17:08:14] Niklas Laxström: clicking ULS
[17:08:32] Niklas Laxström: display settings
[17:08:36] Niklas Laxström: fonts
[17:08:41] Niklas Laxström: OD for content and ui (german)
[17:08:50] Niklas Laxström: input
[17:09:03] Niklas Laxström: selecting deutsch tilde
[17:09:08] Niklas Laxström: save
[17:09:17] Niklas Laxström: reload
[17:09:47] Niklas Laxström: I see OD selected, but my ime is native tastatur

Change 96750 had a related patch set uploaded by Amire80:
WIP: A new test for bug 56885

https://gerrit.wikimedia.org/r/96750

Gerrit 96750 was merged.

Change 102102 had a related patch set uploaded by Zfilipin:
Removing pending block for a bug that was resolved

https://gerrit.wikimedia.org/r/102102

Change 102102 merged by jenkins-bot:
Removing pending block for a bug that was resolved

https://gerrit.wikimedia.org/r/102102