Page MenuHomePhabricator

MultimediaViewer shouldn't interfere with middle click
Closed, ResolvedPublic


Author: nzmoihue

When I middle click or Ctrl+Click on an image, I don't expect MultiMediaViewer file viewer opened.

Version: unspecified
Severity: minor



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:29 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz56905.
bzimport added a subscriber: Unknown Object (MLST).

I have fixed this issue in so many random places in the past that I have a snippet ready :P

// Do not interfere with non-left clicks or if modifier keys are pressed.
if ( e.which !== 1 || e.altKey || e.ctrlKey || e.shiftKey || e.metaKey ) {



Mind converting that into patch form? :D

Will do as soon as you get me an extra day in the week. :P

I've filed a bug against Wikimedia/Site configuration to change the week structure on the cluster, please stand by.

Change 94971 had a related patch set uploaded by Ebrahim:
Don't interfere with middle click

Change 94971 merged by jenkins-bot:
Don't interfere with middle click

Thanks, Ebrahim!

Also MatmaRex, though I have to say, I'm disappointed with your lack of follow-through. :P

Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:21 AM