Page MenuHomePhabricator

File page should use HiDPI src-set for nominal-size rendering
Closed, ResolvedPublic

Description

The image rendering on the File page doesn't use a HiDPI srcset, causing it to look rather pixelated on HiDPI displayed, especially when coming from a page where a thumbnail is shown of the image.

And thumbnails do use a HiDPI srcset, and I bet a significant amount of traffic to file pages comes from clicks on thumbnails.


Version: 1.21.x
Severity: minor
Whiteboard: gci2013
URL: https://google-melange.appspot.com/gci/task/view/google/gci2013/6705304553127936

Details

Reference
bz56969

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz56969.
bzimport added a subscriber: Unknown Object (MLST).
Krinkle created this task.Nov 12 2013, 10:30 PM

Looks easy to do.

t.lam wrote:

I'm a GCI student that just claimed this task today. I was trying to get started but couldn't find where I'm supposed to change the file page. Also is the code that I'm told to reuse the methods in the Linker class for responsive images?

Change 96196 had a related patch set uploaded by Brian Wolff:
Updated File page to use HiPI

https://gerrit.wikimedia.org/r/96196

(In reply to comment #3)

Change 96196 had a related patch set uploaded by Brian Wolff:
Updated File page to use HiPI

https://gerrit.wikimedia.org/r/96196

Just to clarify there, I have nothing to do with this patchset (I added a single newline to the commit message), gerrit bot apparently just likes to use commiter name instead of author :(.

Change 96196 abandoned by Tholam:
Updated File page to use HiPI

https://gerrit.wikimedia.org/r/96196

Change 96212 had a related patch set uploaded by Tholam:
Updated ImagePage to use HiPI

https://gerrit.wikimedia.org/r/96212

Change 96414 had a related patch set uploaded by Tholam:
Updated ImagePage to use HiDPI (GCI Student)

https://gerrit.wikimedia.org/r/96414

Change 96212 abandoned by Tholam:
Updated ImagePage to use HiPI

https://gerrit.wikimedia.org/r/96212

Change 96414 abandoned by Tholam:
Updated ImagePage to use HiDPI (GCI Student)

https://gerrit.wikimedia.org/r/96414

Change 96416 had a related patch set uploaded by Tholam:
Updated ImagePage to use HiDPI

https://gerrit.wikimedia.org/r/96416

Change 96416 merged by jenkins-bot:
Update ImagePage to use HiDPI

https://gerrit.wikimedia.org/r/96416