Page MenuHomePhabricator

Refreshing page makes editor go strange
Closed, ResolvedPublic

Description

Click edit button to load the editor.
In editor.js add an alert to the callback for:

mw.loader.using( 'mobile.editor', function() {

THe router fires this alert twice. This seems to create 2 api requests... so not good.


Version: unspecified
Severity: normal

Details

Reference
bz56973

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz56973.

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1397

Sorry this bug isn't clear.
When the hash is #editor/0 and you hit refresh the router fires twice. I'm not sure if this is problematic or not but seems strange. If I then edit and click the back button I get 2 confirmation messages to leave the editor overlay

jgonera wrote:

I tracked this down. Working on a fix.

Change 95988 had a related patch set uploaded by JGonera:
Don't run Router#checkRoutes externally

https://gerrit.wikimedia.org/r/95988

Change 95988 merged by jenkins-bot:
Don't run Router#checkRoutes externally

https://gerrit.wikimedia.org/r/95988