Page MenuHomePhabricator

Implement serialisation of <meta property="mw:PageProp/notoc" /> and <meta property="mw:PageProp/forcetoc" />
Closed, ResolvedPublic

Description

These are currently implements in WT->HTML but not the other way around. Blocking further work on TOC status in VE - gerrit 95103.


Version: unspecified
Severity: normal

Details

Reference
bz56983

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz56983.

This seems a bug in serializing new meta tags without data-parsoid. See below. Taking this and fixing.


[subbu@earth lib] echo "NOTOC" | node parse --fetchConfig false --wt2wt
NOTOC
[subbu@earth lib] echo "<meta property='mw:PageProp/notoc' data-parsoid='{&quot;src&quot;:&quot;NOTOC&quot;,&quot;magicSrc&quot;:&quot;NOTOC&quot;}'/>" | node parse --html2wt
NOTOC
[subbu@earth lib] echo "<meta property='mw:PageProp/notoc' />" | node parse --html2wt
notoc

Change 95574 had a related patch set uploaded by Subramanya Sastry:
(Bug 56983) Correctly serialize magic words added on client

https://gerrit.wikimedia.org/r/95574

Change 95574 merged by jenkins-bot:
(Bug 56983) Correctly serialize magic words added on client

https://gerrit.wikimedia.org/r/95574

(In reply to comment #3)

Change 95574 merged by jenkins-bot:
(Bug 56983) Correctly serialize magic words added on client

https://gerrit.wikimedia.org/r/95574

Does this mean this bug can be marked as FIXED?

Yes, and marking as such.

Change 101262 had a related patch set uploaded by GWicke:
Merge "(Bug 56983) Correctly serialize magic words added on client"

https://gerrit.wikimedia.org/r/101262

Change 101298 had a related patch set uploaded by GWicke:
(Bug 56983) Correctly serialize magic words added on client

https://gerrit.wikimedia.org/r/101298

Change 101262 merged by GWicke:
Merge "(Bug 56983) Correctly serialize magic words added on client"

https://gerrit.wikimedia.org/r/101262

Change 101298 merged by GWicke:
(Bug 56983) Correctly serialize magic words added on client

https://gerrit.wikimedia.org/r/101298