Page MenuHomePhabricator

GuidedTourHooks::onResourceLoaderRegisterModules failed to return true
Closed, ResolvedPublic

Description

This looks like a straightforward missing 'return true', but that doesn't explain why it wasn't detected earlier.


Version: master
Severity: normal

Details

Reference
bz57090

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz57090.

The reason I didn't notice this is because it's not required since https://gerrit.wikimedia.org/r/#/c/70328/ .

Now that I understand the issue, I'll still do this for backwards compatibility.

Change 96164 had a related patch set uploaded by Mattflaschen:
Add return true to hook for back-compat with older core.

https://gerrit.wikimedia.org/r/96164

Change 96164 merged by jenkins-bot:
Add return true to hook for back-compat with older core.

https://gerrit.wikimedia.org/r/96164