Page MenuHomePhabricator

Legend message broken on Special:CentralNoticeBanners
Open, LowPublic

Description

Original reporter: @Umherirrender (bug 57109)


When looking at https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners with a Internet Explorer the fieldset has labels like:
<-header>
<-banner-search>
<-banner-bulk-manage>
<-one-off>
<-addBanner>
<-banner-list>

Looks like the prefix in the messages is missing.

Screen Shot 2017-04-06 at 16.13.25.png (1×1 px, 1 MB)

Details

Reference
bz57109

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:14 AM
bzimport set Reference to bz57109.
bzimport added a subscriber: Unknown Object (MLST).

mwalker wrote:

It's sort of 'on purpose'. They don't have labels because the form itself should be rendering with the fieldset labels hidden (no point translating something no one will ever see for longer than however long it takes for the CSS to load).

I would just not use fieldsets; but sadly the internal component HTMLForm doesn't seem to allow that.

OTOH; if the page is rendering slow enough that you see them perhaps I need to look at using inline styles to hide the things. I'll mark this WONTFIX for the moment; but I'm open to other suggestions if it really is annoying.

It is not about load time, the javascript or css to format the page does not work in IE8, so the fieldset are shown as there are all under the other. No grouping like in FireFox.

Please have a look with Internet Explorer 8. Thanks.

Krinkle renamed this task from No CSS/JavaScript on Special:CentralNoticeBanners in Internet Explorer to Legend message broken on Special:CentralNoticeBanners.Apr 6 2017, 11:18 PM
Krinkle updated the task description. (Show Details)
Krinkle removed a subscriber: wikibugs-l-list.
Krinkle added a subscriber: AndyRussG.

While the JavaScript run-time is no longer enabled for IE8 (we require IE9+ now), it seems the original issue as reported here has no relation to IE8.

CentralNotice is producing a form here with legends that contain broken messages. I can see this even in Chrome at https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners when inspecting the DOM:

Screen Shot 2017-04-06 at 16.15.51.png (488×1 px, 147 KB)

These legends are hidden from view by the following lazy-loaded CSS rule (which naturally doesn't get a chance to be loaded in older browsers on Grade C):

#cn-banner-manager legend {
  display: none;
}

Three issues:

  • These message keys used should not be undefined. Right now it's trying to parse a message by the key of -header, -addBanner, -removeBanner etc. which is just plain broken. The key should be fixed to something that belongs to centralnotice, and (if the messages really don't exist) the message keys should then also be defined to actually contain some kind of label.
  • If these legends are never of any use, maybe the server-side should not be producing them in the first place.
  • If we want to continue to hide them with CSS, the CSS should be loaded through a page style module instead of lazy-loaded with JavaScript.

@Umherirrender, could you or anyone else perhaps confirm if this is still an issue today? Thanks much!!!

@Umherirrender, could you or anyone else perhaps confirm if this is still an issue today? Thanks much!!!

You can still find <legend>⧼-header⧽</legend> in the source code of that page, but I have not disabled javascript to see it. It just plain html code as provided by the server.