Page MenuHomePhabricator

Images show as new pages
Closed, ResolvedPublic

Description

view https://en.m.wikipedia.org/wiki/File:Larry_Long_Guitar_Standing.jpg in stable.
Compare it with beta:
https://en.m.wikipedia.org/wiki/File:Larry_Long_Guitar_Standing.jpg?mobileaction=beta

In beta it doesn't check Commons. This means links from the profile page take you to a blank page. No bueno.


Version: unspecified
Severity: normal

Details

Reference
bz57155

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:17 AM
bzimport added a project: MobileFrontend-beta.
bzimport set Reference to bz57155.

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1421

jgonera wrote:

Both URLs show the same picture for me. Am I missing something?

Are you in beta and using instant commons magic?

I can confirm comment 0 (Firefox 25).

I can only replicate this issue when I am logged in to the project.

See SkinMobileBeta::handleNewPages

andrew.green.df wrote:

(In reply to comment #6)

See SkinMobileBeta::handleNewPages

Confirmed: in that method there's a test that incorrectly sends us to the create page prompt.

https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend/3ea1a92f2f20cef1ba853c3e1cfa9c2539236936/includes%2Fskins%2FSkinMobileBeta.php#L100

I'm just digging around to find the proper way to fix it, shouldn't be too long...

Change 100753 had a related patch set uploaded by AndyRussG:
Don't handle new pages for images or categories

https://gerrit.wikimedia.org/r/100753

Change 100753 merged by jenkins-bot:
Don't handle new pages for files

https://gerrit.wikimedia.org/r/100753