Page MenuHomePhabricator

Core jquery.placeholder module and github.com/mathiasbynens/jquery-placeholder should be merged
Closed, ResolvedPublic

Description

Core jquery.placeholder module and https://github.com/mathiasbynens/jquery-placeholder should be merged. Both are polyfills for 'placeholder' attribute implementation, with each having some features missing from the other one.

Both are MIT-licensed (as of https://gerrit.wikimedia.org/r/#/c/95748/).


Version: unspecified
Severity: enhancement
Whiteboard: gci2013
URL: https://google-melange.appspot.com/gci/task/view/google/gci2013/4944888458117120

Details

Reference
bz57179

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz57179.
bzimport added a subscriber: Unknown Object (MLST).

Features we are missing:

  • Support for valHooks and propHooks (bug 55651)
  • Clearing placeholders upon form submission (bug 47057)

Features mathiasbynens/jquery-placeholder is missing (bug 47057 comment 5):

  • Calling it as $(…).placeholder('Placeholder text') to set placeholder (its .placeholder function doesn't accept any arguments).
  • Support for inserting values into inputs with placeholders defined – dragging text or rightclick-pasting it could result in new value being appended to the placeholder or inserted in the middle of it.

Change 98137 had a related patch set uploaded by MegaAlex:
Merge jquery.placeholder with github.com/mathiasbynens/jquery-placeholder

https://gerrit.wikimedia.org/r/98137

Change 98137 merged by jenkins-bot:
Merge jquery.placeholder with github.com/mathiasbynens/jquery-placeholder

https://gerrit.wikimedia.org/r/98137

Done. Thanks!