Page MenuHomePhabricator

CentralAuth $wgSecureLogin redirect is uncacheable
Closed, ResolvedPublic

Description

The redirect added to CentralAuth in Ia1232ac39e8 is effectively uncacheable, since it depends on wfCanIPUseHTTPS(), which can't be varied on in Varnish. The change should probably be reverted. It's essential that /checkLoggedIn be cached if the backend request rate impact of CentralAuth is to be reduced.


Version: unspecified
Severity: normal

Details

Reference
bz57223

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz57223.

Change 96317 had a related patch set uploaded by CSteipp:
Remove https redirect from CentralAutoLogin

https://gerrit.wikimedia.org/r/96317

As noted on the patch, that should have been a redundant check, so the AutoLogin piece should be cacheable with gerrit 96317.

Change 96317 merged by jenkins-bot:
Remove https redirect from CentralAutoLogin

https://gerrit.wikimedia.org/r/96317

bd808 moved this task from Tag to Archive on the Performance board.Mar 11 2015, 7:31 PM