Page MenuHomePhabricator

Alpha: URL specific to page section is lost after reloading
Closed, ResolvedPublic

Description

Details

Reference
bz57329

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:29 AM
bzimport set Reference to bz57329.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1432

Andre / Quim - very easy task for Google Code in 2013. Only danger is someone might fix it before they get a chance to.

Qgil added a comment.Dec 24 2013, 7:53 PM

Looks like a good GCI task. It has been around for more than a month. It might take some hours until someone claims it in GCI. Please create it.

Change 104314 had a related patch set uploaded by M4tx:
Fix section hash url lost after reloading page in alpha

https://gerrit.wikimedia.org/r/104314

m4tx added a comment.Dec 28 2013, 8:21 PM

Done the task, I think. Although the fix is very simple, it was not so simple for me to find out where the bug really is... Anyway, it's browser-specific bug - there was no such problem on Firefox, though there actually was on Chrome.

m4tx added a comment.Dec 28 2013, 8:35 PM

Oh. It's not really a browser-specific bug; just the MobileFrontend's isBrowserSupported() (which checks if browser supports session history management) function defined in javascripts/externals/epoch.js returns true only for Chrome and iOS browser...

Anyway - I think it's time to update this function since almost all browsers currently support it - http://caniuse.com/history.

Yeh isBrowserSupported was made as limited as possible on purpose to limit testing of what is a highly experimental feature. This is changing as part of this experiment: https://gerrit.wikimedia.org/r/#/c/100919/

Change 104314 merged by jenkins-bot:
Fix section hash url lost after reloading page in alpha

https://gerrit.wikimedia.org/r/104314

m4tx added a comment.Dec 28 2013, 8:45 PM

Hm. I've already created a bug report, but since it's already being solved, as @Jon says, it could be not very smart...

Anyway. Bug: 59087.