Page MenuHomePhabricator
Create Task
Maniphest T59375

remove echowikis to simplify configuration
Closed, DeclinedPublic
Actions

Description

With https://gerrit.wikimedia.org/r/#/c/96536/ , Echo is deployed on all 877 WMF wikis. So echowikis.dblist is unneeded (it's the same as all.dblist except for ordering). (it is no longer on all wikis).

In that commit Benny comments:
@Todo - echowikis.dblist is used by a cron to send daily/weekly digest email, with Echo enabled on all wikis, this file becomes redundant, we can set the cron to execute with foreachwiki blah.php instead of foreachwikiindblist echowikis.dblist.
This is class misc::maintenance::echo_mail_batch in puppet/manifests/misc/maintenance.pp

So first that should be changed in Puppet, and then echowikis.dblist and references to it can be removed from mediawiki-config configuration.

Version: unspecified
Severity: minor

Details

Reference
bz57375
SubjectRepoBranchLines +/-
Enable Echo on Wikimedia wikis by defaultoperations/mediawiki-configmaster+11 -893
Remove dependency on echowikis.dblistoperations/puppetproduction+1 -1
Make processEchoEmailBatch check that Echo is actually enabled before doing anythingmediawiki/extensions/Echomaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:32 AM
• bzimport added a project: Wikimedia-Extension-setup.
• bzimport set Reference to bz57375.
• bzimport added a subscriber: Unknown Object (MLST).
• Spage created this task.Nov 21 2013, 9:56 PM
Krenair assigned this task to Withoutaname.EditedMay 31 2015, 12:00 PM
Krenair subscribed.

https://gerrit.wikimedia.org/r/#/c/139326/5

Edit: Also https://gerrit.wikimedia.org/r/#/c/139581/

Krenair added a comment.May 31 2015, 12:01 PM

@Todo - echowikis.dblist is used by a cron to send daily/weekly digest email, with Echo enabled on all wikis, this file becomes redundant, we can set the cron to execute with foreachwiki blah.php instead of foreachwikiindblist echowikis.dblist.

It's not enabled on literally every wiki, this could cause errors - see https://phabricator.wikimedia.org/T97760#1274418

Krenair added a parent task: T97760: Enable Echo on all Wikimedia wikis.May 31 2015, 12:19 PM
gerritbot subscribed.May 31 2015, 12:25 PM

Change 214913 had a related patch set uploaded (by Alex Monk):
Make processEchoEmailBatch check that Echo is actually enabled before doing anything

https://gerrit.wikimedia.org/r/214913

gerritbot added a project: Patch-For-Review.May 31 2015, 12:25 PM
Krenair claimed this task.May 31 2015, 12:26 PM
Krenair added a subscriber: Withoutaname.
gerritbot added a comment.Jun 2 2015, 1:16 AM

Change 214913 merged by jenkins-bot:
Make processEchoEmailBatch check that Echo is actually enabled before doing anything

https://gerrit.wikimedia.org/r/214913

Krenair mentioned this in rECHO6157c1e7bbc3: Make processEchoEmailBatch check that Echo is actually enabled before doing….Jun 2 2015, 1:16 AM
Diffusion mentioned this in rMEXT68d1d18de99c: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Jun 2 2015, 1:16 AM
Krenair removed a project: Patch-For-Review.Jun 2 2015, 1:53 AM
Krenair set Security to None.
• Mattflaschen-WMF updated the task description. (Show Details)Jun 3 2015, 3:03 AM
• Mattflaschen-WMF added a project: Notifications.
• Mattflaschen-WMF subscribed.

I like having a dblist so foreachwikiindblist can be used (it's somewhat weird to make code in Echo check that Echo is enabled). However, another solution (to still get the maintainability benefits) is T101213: foreachwikiindblist to run scripts on all wikis matching a dblist expression.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 3 2015, 3:05 AM
Legoktm subscribed.Jun 3 2015, 3:47 AM

You can use foreachwiki and ignore the exceptions on 2? wikis. That's what we do for CentralAuth.

• Mattflaschen-WMF added a comment.Jun 3 2015, 5:06 AM

I don't like seeing exceptions when running stuff. People shouldn't have to remember which are 'expected' exceptions.

gerritbot added a comment.Jun 14 2015, 8:49 PM

Change 139581 had a related patch set uploaded (by Alex Monk):
Remove echowikis.dblist

https://gerrit.wikimedia.org/r/139581

gerritbot added a project: Patch-For-Review.Jun 14 2015, 8:49 PM
gerritbot added a comment.Jun 14 2015, 9:54 PM

Change 139326 had a related patch set uploaded (by Alex Monk):
Enable Echo on Wikimedia wikis by default

https://gerrit.wikimedia.org/r/139326

Liuxinyu970226 subscribed.Jun 24 2015, 11:15 AM
Krenair added a project: Blocked-on-Operations.Jun 25 2015, 3:38 PM

Blocked on someone in operations reviewing https://gerrit.wikimedia.org/r/#/c/139581/

Legoktm moved this task from Backlog to External on the Notifications board.Jul 6 2015, 7:23 AM
gerritbot added a comment.Jul 14 2015, 5:46 PM

Change 139581 merged by Dzahn:
Remove dependency on echowikis.dblist

https://gerrit.wikimedia.org/r/139581

Dzahn mentioned this in rOPUP79b721d77cfa: Remove dependency on echowikis.dblist.Jul 14 2015, 5:46 PM
Krenair removed a project: Blocked-on-Operations.Jul 15 2015, 5:50 AM
gerritbot added a comment.Jul 15 2015, 3:10 PM

Change 139326 merged by jenkins-bot:
Enable Echo on Wikimedia wikis by default

https://gerrit.wikimedia.org/r/139326

Krenair mentioned this in rOMWC7abe93a63e20: Enable Echo on Wikimedia wikis by default.Jul 15 2015, 3:10 PM
Krenair closed this task as Resolved.Jul 15 2015, 3:39 PM
Liuxinyu970226 unsubscribed.Jul 15 2015, 11:56 PM
Quiddity moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jul 29 2015, 11:57 PM
Legoktm mentioned this in T137771: "Echo isn't enabled on this wiki" from Cron <www-data@terbium> /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null.Jun 14 2016, 9:18 AM
Legoktm changed the task status from Resolved to Declined.Jun 14 2016, 5:20 PM

This was effectively reverted in T137771: "Echo isn't enabled on this wiki" from Cron <www-data@terbium> /usr/local/bin/foreachwiki extensions/Echo/maintenance/processEchoEmailBatch.php >/dev/null.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL