Page MenuHomePhabricator

Typography refresh dramatically increase Wikibase items label font
Closed, ResolvedPublic

Description

Screenshot of the issue

There looks like to be an issue between Wikibase and Typographic refresh beta option: Wikibase item label, in view and edit mode, looks very big when the option is activated.


Version: master
Severity: normal

Attached:

Details

Reference
bz57436

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:36 AM
bzimport set Reference to bz57436.
Tpt created this task.Nov 22 2013, 6:35 PM

I think this would be better recorded - https://www.mediawiki.org/wiki/Talk:Typography_Update

This feature is actually provided by VectorBeta so filed in the wrong place. It is very likely to disappear into Bugzilla by being placed here...

Jon, I think you have the 'editbugs' right? Do move the bug in a better place.

It's difficult to tell what is the right place for me at least, though, since the feature is partially in core and partially in two different extensions. There is also no component for VectorBeta, I think you should get that fixed.

(In reply to comment #2)

There is also no component for VectorBeta, I think you should get that fixed.

https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component

I'd say that WikiData is the component this bug belongs to. Here are the relevant styles:

The headline is a <h1 class="wb-value-row wb-firstHeading"><span class="wb-value">Foo</span></h1> (plus lots of other classes and ids, but these are the relevant ones).

Normal Vector styles are

h1 { font-size: 188%; }

Beta Vector styles are

#content h1 { font-size: 1.833em; }

(which is almost the same, but more specific)

WikiData styles are

.wb-value-row { font-size: 100%; }
.wb-firstHeading .wb-value { font-size: 188%; }

So in normal Vector the .wb-value-row style overrides the style for h1, and the headline ends up at font-size: 188%, while in Beta the font-size: 100% do not override the 1.833em;, and the final size is 1.833em * 188% = 345%.

On the other hand: Just removing the #content from the #content h1 selector may be easier (and there are no <h1> outside #content anyway), which would mean that MediaWiki Core > Skin and page rendering would be the best component for this bug.

Tpt: Browser information welcome. Also, how to reproduce the problem (steps)?

Tentatively moving to Wikidata as per comment 4.
Wikidata folks: Feel free to move to "MediaWiki > Skin and page rendering" as per comment 5.

Change 115893 had a related patch set uploaded by Thiemo Mättig (WMDE):
Typography refresh (VectorBeta extension) makes heading font to big

https://gerrit.wikimedia.org/r/115893

Change 115893 merged by jenkins-bot:
Typography refresh (VectorBeta extension) makes heading font to big

https://gerrit.wikimedia.org/r/115893

mr.heat wrote:

I fixed this while working on a related design issue with the table of contents (TOC).

Please note that this is a temporary workaround and it's not perfect. The Typography refresh is still in Beta and will change. Please re-open this report if the issue re-appears or the Beta feature causes other issues.

Just to let you know, there is a very closely related change at https://gerrit.wikimedia.org/r/123203 that fixes a wrong font family used.