Page MenuHomePhabricator
Create Task
Maniphest T59541

TranslateRenderJob.php: Oops, this should not happen!
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

2013-11-25 15:58:38 mw1013 mediawikiwiki: [341bb6e2] [no req] Exception from line 46 of /usr/local/apache/common-local/php-1.23wmf5/extensions/Translate/tag/TranslateRenderJob.php: Oops, this should not happen!
#0 /usr/local/apache/common-local/php-1.23wmf5/maintenance/runJobs.php(101): TranslateRenderJob->run()
#1 /usr/local/apache/common-local/php-1.23wmf5/maintenance/doMaintenance.php(113): RunJobs->execute()
#2 /usr/local/apache/common-local/php-1.23wmf5/maintenance/runJobs.php(181): require_once('/usr/local/apac...')
#3 /usr/local/apache/common-local/multiversion/MWScript.php(97): require_once('/usr/local/apac...')
#4 {main}

By the timings of this.. I think it was a result of me marking a few help pages on mediawiki.org for translation...

Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=46716

Details

Reference
bz57541
SubjectRepoBranchLines +/-
Fix checkmediawiki/extensions/Translatemaster+1 -1
Fix one instance of 'MWException' with message 'Oops, this should not happen!'mediawiki/extensions/Translatemaster+5 -0
Fix uncaught exception when moving documentation unit of translatable pagemediawiki/extensions/Translatemaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:15 AM
• bzimport added a project: MediaWiki-extensions-Translate.
• bzimport set Reference to bz57541.
• bzimport added a subscriber: Unknown Object (MLST).
Reedy created this task.Nov 25 2013, 4:01 PM
Nikerabbit added a comment.Nov 25 2013, 8:33 PM

I propose changing the text from "this should not happen" to "this must not happen" ;)

Honestly though, it should not happen.

Nemo_bis added a comment.Nov 20 2014, 9:32 AM

(In reply to Sam Reed (reedy) from comment #0)

By the timings of this.. I think it was a result of me marking a few help
pages on mediawiki.org for translation...

It's not surprising then that marking pages for translation usually fails. Cf. https://bugzilla.wikimedia.org/show_bug.cgi?id=46716#c29
We really need to have more useful output.

Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Jan 28 2015, 5:05 AM
• demon added a project: Wikimedia-production-error.Feb 18 2015, 7:55 PM
• demon set Security to None.
Nikerabbit merged a task: T90597: When moving a /qqq documentation page to other name I'm getting an error.Feb 28 2015, 11:28 AM
Nikerabbit added subscribers: Aklapper, Stryn.

@Stryn did you test if this exception is reproducible?

Stryn added a comment.EditedFeb 28 2015, 2:32 PM
In T59541#1075562, @Nikerabbit wrote:

@Stryn did you test if this exception is reproducible?

Yes, I tried it again, and it seems occurring only in the "Translation" namespace.
I tried the same in the "CNBanner" namespace and didn't get any errors.

Nikerabbit added a comment.Feb 28 2015, 7:34 PM

When I try on my development instance I only get some warnings:

Notice: WikiPage::doPurge: Explicit commit of implicit transaction. Something may be out of sync! [Called from DatabaseBase::commit in /www/dev.translatewiki.net/docroot/w/includes/db/Database.php at line 3688] in /www/dev.translatewiki.net/docroot/w/includes/debug/MWDebug.php on line 300

Notice: WikiPage::doPurge: No transaction to commit, something got out of sync! [Called from DatabaseBase::commit in /www/dev.translatewiki.net/docroot/w/includes/db/Database.php at line 3685] in /www/dev.translatewiki.net/docroot/w/includes/debug/MWDebug.php on line 300

Nikerabbit added a comment.Feb 28 2015, 7:40 PM

Okay, it only happens for qqq.

gerritbot subscribed.Feb 28 2015, 7:51 PM

Change 193584 had a related patch set uploaded (by Nikerabbit):
Fix uncaught exception when moving documentation unit of translatable page

https://gerrit.wikimedia.org/r/193584

gerritbot added a project: Patch-For-Review.Feb 28 2015, 7:51 PM
Nikerabbit claimed this task.Feb 28 2015, 7:52 PM
gerritbot added a comment.Mar 3 2015, 6:42 PM

Change 193584 merged by jenkins-bot:
Fix uncaught exception when moving documentation unit of translatable page

https://gerrit.wikimedia.org/r/193584

Nikerabbit mentioned this in rETRA3c6ce8f9060d: Fix uncaught exception when moving documentation unit of translatable page.Mar 3 2015, 6:42 PM
greg subscribed.Mar 6 2015, 11:07 PM
In T59541#1083366, @gerritbot wrote:

Change 193584 merged by jenkins-bot:
Fix uncaught exception when moving documentation unit of translatable page

https://gerrit.wikimedia.org/r/193584

that patch is now merged, is this issue resolved?

greg removed a project: Patch-For-Review.Mar 6 2015, 11:08 PM
Nikerabbit closed this task as Resolved.Mar 7 2015, 9:54 AM

I don't know where in earth I should be looking to see the logs, but I didn't find any of these in logstash.

Diffusion mentioned this in rMEXT2c560d7d8ea3: Updated mediawiki/extensions Project: mediawiki/extensions/Translate….Mar 11 2015, 6:28 AM
gerritbot added a comment.May 24 2015, 11:35 AM

Change 213232 had a related patch set uploaded (by Nemo bis):
Fix one instance of 'MWException' with message 'Oops, this should not happen!'

https://gerrit.wikimedia.org/r/213232

gerritbot added a project: Patch-For-Review.May 24 2015, 11:35 AM
He7d3r mentioned this in T48716: Translation page does not contain the latest translations/last translation.Jun 9 2015, 6:40 PM
• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jun 12 2015, 6:36 PM
gerritbot added a comment.Jul 1 2015, 7:31 AM

Change 213232 merged by jenkins-bot:
Fix one instance of 'MWException' with message 'Oops, this should not happen!'

https://gerrit.wikimedia.org/r/213232

Diffusion mentioned this in rMEXT6d6c5eab997b: Updated mediawiki/extensions Project: mediawiki/extensions/Translate….Jul 1 2015, 7:31 AM
Nemo_bis mentioned this in rETRAacbb2d5879df: Fix one instance of 'MWException' with message 'Oops, this should not happen!'.Jul 1 2015, 7:31 AM
• Forrestbot added a project: WMF-deploy-2015-07-07_(1.26wmf13).Jul 1 2015, 8:00 AM
Nikerabbit mentioned this in T116617: TranslateRenderJob: "Oops, this should not happen!".Dec 11 2015, 3:14 PM
gerritbot added a comment.Mar 4 2016, 3:48 AM

Change 274897 had a related patch set uploaded (by Siebrand):
Fix check

https://gerrit.wikimedia.org/r/274897

gerritbot added a comment.Mar 4 2016, 1:48 PM

Change 274897 merged by jenkins-bot:
Fix check

https://gerrit.wikimedia.org/r/274897

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)).Mar 4 2016, 2:00 PM
Glaisher merged a task: T87081: Attempt of rename translation item => internal error.May 28 2016, 4:26 PM
Glaisher added subscribers: Amire80, Kaganer.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL