Page MenuHomePhabricator

CentralAuth Special:GlobalUsers has useless edit controls ("Show only users with edits", "Sort by creation date")
Closed, ResolvedPublic

Description

Author: zsaigol

Description:
In CentralAuth, the file SpecialGlobalUsers.php has a class GlobalUsersPager which extends UsersPager. UsersPager is the implementation for Special:ListUsers in MediaWiki core.

This means that Special:GlobalUsers inherits the "Show only users with edits" and "Sort by creation date" checkboxes, but these controls have no effect on the output. Also the "Sort in descending order" checkbox behaves stangely.


Version: master
Severity: minor

Details

Reference
bz57544

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz57544.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Nov 25 2013, 4:44 PM

zsaigol wrote:

A fix for this bug will be useful for Bug 33545, as it will make fixing that bug much easier. (see https://bugzilla.wikimedia.org/show_bug.cgi?id=33545 and https://gerrit.wikimedia.org/r/#/c/79041/)

zsaigol wrote:

Gerrit patchset: https://gerrit.wikimedia.org/r/#/c/97531/
I've just removed the the "Show only users with edits" and "Sort by creation date" checkboxes. I suspect the "Sort in descending order" still interacts weirdly with the username box, but I don't have any real way of testing it, as it seems to require several instances of a wiki plus some complex DB tables to be populated to test properly.

Change 97531 had a related patch set uploaded by Nemo bis:
Changed Special:GlobalUsers to inherit from AlphabeticPager

https://gerrit.wikimedia.org/r/97531

Change 97531 merged by jenkins-bot:
Changed Special:GlobalUsers to inherit from AlphabeticPager

https://gerrit.wikimedia.org/r/97531