Page MenuHomePhabricator

make it possible to show the + sign in quantities on item pages
Open, NormalPublic

Description

Some quantity properties will need to be able to show the plus sign while it should be hidden in most cases. We need to figure out the best way to do this and then implement it.


Version: master
Severity: normal
Whiteboard: quantityvalue, u=dev c=backend p=0

Details

Reference
bz57589

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:19 AM
bzimport set Reference to bz57589.
bzimport added a subscriber: Unknown Object (MLST).

The first step would be to have an options for DecimalFormatter and QuantityFormatter to force the sign.

That leaves the question how exactly a property would be marked for "keeping the sign", and how and when formatters would be made aware of this.

A possible solution would be to keep the sign only when it was explicitly typed by the user. Another one would be to specify that in the property page with qualifiers ("preferred unit"="meter" and "preferred formatting"=> "always display + symbol"), however this second option depends on https://bugzilla.wikimedia.org/show_bug.cgi?id=49554

Change 97768 had a related patch set uploaded by Daniel Kinzler:
(bug 57589) option to force "+" in decimal values.

https://gerrit.wikimedia.org/r/97768

Change 97768 merged by jenkins-bot:
(bug 57589) option to force "+" in decimal values.

https://gerrit.wikimedia.org/r/97768

The formatter now supports it but we still need a way to handle this on Wikipedia and on the item pages. We need to figure out how to best store this information for properties that need it.

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
ResMar added a subscriber: ResMar.Dec 31 2015, 9:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 31 2015, 9:20 PM
ResMar removed a subscriber: ResMar.Apr 15 2016, 1:43 PM