Page MenuHomePhabricator

Login page JavaScript exception: Error: Template not found: overlays/cleanup Error {}
Closed, ResolvedPublic

Description

https://m.mediawiki.org/wiki/Special:UserLogin

Exception thrown by mobile.issues.beta load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2Cl…:145
Error: Template not found: overlays/cleanup Error {} load.php?d


Version: unspecified
Severity: normal

Details

Reference
bz57624

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:22 AM
bzimport added a project: ZeroPortal.
bzimport set Reference to bz57624.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1455

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1458

  • Bug 57766 has been marked as a duplicate of this bug. ***

Yuri - how are you replicating this and on what wiki?

From IRC:

yurik-road:
awjr, seems like i can still repo it - https://en.m.wikipedia.org/wiki/New_York?debug=true -- and make sure you spoof X-CS=250-99 and User-Agent=android

I can verify - after setting my x-cs headers, I was able to trigger the error. Is this a zero bug though rather than mobilefrontend?

See attached screenshot.

Created attachment 13966
Errors in action

Attached:

Looks like an issue with Zero.
'class' => 'MFResourceLoaderModule',

Several issues:

  1. mobile.zero.scripts and mobile.zero.templates can now be merged into one module specifying:

'class' => 'MFResourceLoaderModule',

  1. Explicitly add to dependencies for this module: 'mobile.templates'

Basically what is happening is the code for templates is not being loaded before the template is added.

Change 99027 had a related patch set uploaded by Yurik:
Bug 57624: proper js resource loading in zero

https://gerrit.wikimedia.org/r/99027

Change 99027 merged by jenkins-bot:
Bug 57624: proper js resource loading in zero

https://gerrit.wikimedia.org/r/99027