Page MenuHomePhabricator

Use This File dialog is probably broken now
Closed, ResolvedPublic


The refactor of the UI initialisation may have broken this because it changed the value of "this" for the dialog opener function. Should be pretty quick to fix, just use this.$useFile instead of screwing around with $this and $( this ).

Marking as a candidate for GCI, but vandrew might fix it before we can write it up.

Version: unspecified
Severity: normal
Whiteboard: gci2013



Related Objects

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:26 AM
bzimport set Reference to bz57678.
bzimport added a subscriber: Unknown Object (MLST).

Change 98020 had a related patch set uploaded by MarkTraceur:
Replaced this.$useFile instead of with $this inf ext.multimediaViewer.lightboxinterface.js

Change 98020 merged by jenkins-bot:
Fixes the UI refactor

The patch is merged. Is there anything still missing in order to consider this bug fixed?

Use This File is working on right now.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:25 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:23 AM