Page MenuHomePhabricator

items in the Flow action menu have their background icon misaligned in RTL
Closed, ResolvedPublic

Description

The background icon in the menu items under flow-actions-flyout, such as "Hide topic", "Delete topic", "Suppress topic" is misaligned in RTL wikis. I tested it on my own wiki in Hebrew.

In CSS I would change background-position to percentage to get CSSJanus to flip it, but it doesn't seem to work with LESS.


Version: unspecified
Severity: normal

Details

Reference
bz57780

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:32 AM
bzimport set Reference to bz57780.
Amire80 created this task.Nov 30 2013, 8:35 PM

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/546, but people from the community are welcome to contribute here and in Gerrit.

The problem, as I understand it, is on line 43 of Flow/modules/base/styles/mixins/buttonicon.less ( https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FFlow/d0651218fa5986a04ee1090476073383c4f2068b/modules%2Fbase%2Fstyles%2Fmixins%2Fbuttonicon.less )

If I'm not mistaken, pixels are not flipped anywhere, but percentage can be flipped by CSSJanus in CSS. It doesn't seem to be flipped in LESS.

Change 98552 had a related patch set uploaded by Amire80:
Fix menu icon position for RTL

https://gerrit.wikimedia.org/r/98552

Change 98552 merged by jenkins-bot:
Fix menu icon position for RTL

https://gerrit.wikimedia.org/r/98552